fix: skip zero-amount pending mints in ExecuteMints - #49
Merged
Conversation
The script was attempting to execute mint requests with zero token amounts, which caused transaction failures. Add a check to filter out mints where amount is 0 alongside existing checks for executed and vetoed status. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Coverage after merging rsolari/skip-zero-mints into main will be
Coverage Report
|
|||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ExecuteMints script was attempting to execute mint requests with zero token amounts, causing transaction failures. This change filters out zero-amount mints alongside existing checks for executed and vetoed requests.
Changes
amount > 0ncheck to pending mint filter infindPendingMintRequests()🤖 Generated with Claude Code