fix: account for mint delay in reward calculations - #51
Merged
Conversation
…estMint The RequestMint script calculates how many rewards to mint based on current remaining rewards, but the actual mint executes after a configurable delay. By that time, additional rewards have streamed out, causing the resulting APR to undershoot the target. Now we project remaining rewards forward by the mintDelay, so we mint enough to hit the target APR at execution time. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Coverage after merging rsolari/mint-delay-compensation into main will be
Coverage Report
|
|||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The RequestMint script now accounts for the configurable mint delay when calculating required rewards. Previously, it calculated remaining rewards at the current timestamp, but since the mint executes after a delay, additional rewards stream out by execution time, causing undershooting of the target APR.
The fix projects remaining rewards forward by the mintDelay amount, ensuring the minted tokens compensate for rewards streamed during the delay period.
Test plan
--dry-runthat the calculated mint amount reflects delay compensation🤖 Generated with Claude Code