fix: CVE-2024-21538 by migrating to promisify-child-process #4658

[noomorph]

Description

Thanks to the co-author, @matinzd for the initial implementation.

Detox is using a vulnerable package described in CVE-2024-21538.

• This pull request addresses the issue described here: CVE-2024-21538: dependency child-process-promise relies on a version of cross-spawn that is not secure #4657 and Transitive dependency on vulnerable version of cross-spawn #4640

In this pull request, I have migrated away from unmaintained child-promise-process to promisify-child-process to fix the transitive vulnerability on cross-spawn package.

[matinzd]

Thanks for fixing it! Well done 🚀

[d4vidi]

@noomorph general note - I'd like it better if you didn't mix styling changes into technical changes/improvements. It makes it difficult for me / a reviewer to understand what really has changed on the functional level.