Skip to content

🧹 Remove unused defaultdict import and clean up dead code in scout.py #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wjohns989 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧹 Remove unused defaultdict import and clean up dead code in scout.py #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions muninn/retrieval/scout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,12 @@
"""

import logging
import asyncio
import time
from typing import List, Optional, Dict, Any, Tuple
from collections import defaultdict
from typing import List, Optional

from muninn.core.types import SearchResult, MemoryRecord
from muninn.retrieval.hybrid import HybridRetriever
from muninn.core.feature_flags import get_flags
from muninn.core.types import SearchResult
from muninn.retrieval.hybrid import HybridRetriever

logger = logging.getLogger("Muninn.Scout")

Expand All @@ -40,7 +38,7 @@ async def hunt(
"""
t0 = time.time()
flags = get_flags()

# 1. Initial Hybrid Search (Broad)
initial_results = await self.retriever.search(
query=query,
Expand All @@ -51,7 +49,7 @@ async def hunt(
explain=True,
rerank=True
)

# Track effective scope for the final rerank pass. If the fallback
# fires we must propagate the widened (None) scope into the final
# search, otherwise discovered candidates from the fallback are
Expand All @@ -78,7 +76,7 @@ async def hunt(
# Find all entities mentioned in initial results
seed_ids = [r.memory.id for r in initial_results]
discovery_ids = set(seed_ids)

related_entities = set()
for r in initial_results:
meta = r.memory.metadata or {}
Expand All @@ -102,7 +100,7 @@ async def hunt(
# Follow PRECEDES/CAUSES edges from initial seeds
if flags.is_enabled("memory_chains") and seed_ids:
chain_results = self.retriever.graph.find_chain_related_memories(
seed_ids,
seed_ids,
limit=limit
)
for mid, _score in chain_results:
Expand All @@ -114,10 +112,6 @@ async def hunt(
if not all_ids:
return initial_results

# Fetch full records from metadata
records = self.retriever.metadata.get_by_ids(all_ids)
record_map = {r.id: r for r in records}

# Final scoring (Hybrid + Discovery Bonus)
# We re-score the union using the retriever's logic
final_results = await self.retriever.search(
Expand All @@ -134,5 +128,5 @@ async def hunt(
# (This would ideally use an LLM, but we'll build the trace here)
elapsed = time.time() - t0
logger.info("Scout: Hunt completed in %.3fs. Found %d candidates.", elapsed, len(all_ids))
return final_results

return final_results
Loading