Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working patch branch v1 #3

Open
wants to merge 13 commits into
base: price-improvement-threshold
Choose a base branch
from
+624 −335
Open

Working patch branch v1 #3

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b22b0fe
chore: fix capitalization in disruption log (#1530)
njtran Aug 7, 2024
75944ee
chore: Change reason to `NodeClassNotFound` to match `NodeNotFound` (…
jonathan-innis Aug 7, 2024
28fb19d
chore: Minor fixes to disruption logging (#1532)
jonathan-innis Aug 7, 2024
d6f3001
chore: fix nodeClassRef conversion (#1534)
jigisha620 Aug 8, 2024
5758fa2
chore: Fix disruption reason casing (#1535)
jonathan-innis Aug 8, 2024
3e1e3ea
chore: Retain EC2NodeClass reference information during the conversio…
jonathan-innis Aug 9, 2024
ba15aa4
chore: nodePool readiness should validate nodeClass referenced is sup…
jigisha620 Aug 9, 2024
feb6857
fix: ensure NillableDuration is round-trippable (#1545)
jmdeal Aug 12, 2024
71b7bd4
chore: do not set version to NodeClassRef on test environment. (#1559)
liangyuanpeng Aug 12, 2024
92547d1
chore: update max delay for NodeClaim lifecycle controller (#1561)
rschalo Aug 12, 2024
efe3e7d
feat: nodeclaim.spec.priceImprovementThreshold
wmgroot Jul 22, 2024
93c6d91
Expose nodeclaim disruption candidates through nodeclaim condition, a…
cnmcavoy Jun 27, 2024
e42193f
Working consolidation changes
cnmcavoy Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: do not set version to NodeClassRef on test environment. (kuber… 
…netes-sigs#1559)

Signed-off-by: Lan Liang <[email protected]>
@liangyuanpeng
liangyuanpeng authored Aug 12, 2024
commit 71b7bd48910f1559bf14c294ae811e09ac9d0955
2 changes: 1 addition & 1 deletion kwok/README.md
View file
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@ spec:
nodeClassRef:
name: default
kind: KWOKNodeClass
group: karpenter.kwok.sh/v1alpha1
group: karpenter.kwok.sh
expireAfter: 720h # 30 * 24h = 720h
limits:
cpu: 1000
2 changes: 1 addition & 1 deletion test/pkg/environment/common/environment.go
View file
Original file line number Diff line number Diff line change
@@ -162,7 +162,7 @@ func (env *Environment) DefaultNodePool(nodeClass *v1alpha1.KWOKNodeClass) *v1.N
nodePool.Spec.Template.Spec.NodeClassRef = &v1.NodeClassReference{
Name: nodeClass.Name,
Kind: object.GVK(nodeClass).Kind,
Group: object.GVK(nodeClass).GroupVersion().String(),
Group: object.GVK(nodeClass).Group,
}
nodePool.Spec.Template.Spec.Requirements = []v1.NodeSelectorRequirementWithMinValues{
{