Repository navigation
do not allow root time.resolution - #41
Merged
Merged
Conversation
alhelguera
reviewed
Oct 21, 2026
There was a problem hiding this comment.
@tomkralidis there seems to be a bug in the resolution pattern as it is now double escaped:
\\d => \\\\d
Signed-off-by: Tom Kralidis <tomkralidis@gmail.com>
Member
Author
@alhelguera try now? I pushed a fix to the autogen. |
@tomkralidis same as before now, so working as expected. |
joergklausen
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed during WMSR component development, root
time.resolutionshould not be allowed/does not make sense at the facility / aggregate level. This PR updates schemas to forbidtime.resolution.schemas/README.mdbuild steps are also updated in order to preventPointerToNowhereerrors in downstream schemas inheriting WMDR2 core.cc @alhelguera @kurt-hectic @david-i-berry