Complete WNFS Public Filesystem Implementation #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appcypher
force-pushed
the
appcypher/complete-public-fs
branch
from
435c910
to
6095772
Compare
appcypher
changed the title
Codecov Report
@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 79.09% 82.47% +3.37%
==========================================
Files 10 10
Lines 555 759 +204
==========================================
+ Hits 439 626 +187
- Misses 116 133 +17
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
appcypher
force-pushed
the
appcypher/complete-public-fs
branch
from
afe1c5c
to
b0b7665
Compare
appcypher
force-pushed
the
appcypher/complete-public-fs
branch
from
b0b7665
to
acfafaf
Compare
appcypher
force-pushed
the
appcypher/complete-public-fs
branch
from
acfafaf
to
559d5cb
Compare
* Conclude public fs impl * Implement foreign block store * Fix typos and remove console logs * Add new steps for arm-based macOS * Update example. Ts, foreign blockstore, usage * Delete package-lock.json & update yarn.lock * Avoid reference equality in map keys * Remove colon from wnfs.sh shbang Co-authored-by: Philipp Krüger <[email protected]>
Co-authored-by: appcypher <[email protected]>
matheus23
approved these changes
May 17, 2022
|
@appcypher and I have some thoughts on how we could improve |
|
Let's create an issue for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the following features
This is the PR concluding WNFSv2 public file system implementation.
Test plan (required)
Testing the Rust core.
cargo test -p wnfs --releaseTesting the wasm bindings.
cd crates/wasmyarn playwright testClosing issues
Fixes #5
Ongoing Issues