-
Notifications
You must be signed in to change notification settings - Fork 0
vickyctl #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vickyctl #27
Conversation
f0f5e7b
to
4199c9a
Compare
@johannwagner no idea why nix pipeline fails |
I will fix it later. |
Move it from Draft, if you are ready 🙌 |
|
use yansi::Paint; | ||
|
||
#[derive(Debug)] | ||
pub enum Error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You introduced your own error type here and derived manually from it.
In vicky, we use https://docs.rs/thiserror/latest/thiserror/.
Is there a reason for an own error implementation here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes there is. thiserror doesn't give me enough granularity over the error messages the way I would like there to be.
Solid Work! After integration in our pipelines and repositories, we might want to tweak the loading of AppContext a bit, but this may not be part of this pull request. |
Implements #9