Optimize batch order generation performance #184
Draft
+151
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-fetch product, coupon, and customer IDs once per batch to eliminate repeated database queries. This reduces query overhead significantly for large batch operations. Performance improvements: - Products: Single query vs N queries (one per order) - Coupons: Single query vs N queries when using coupon-ratio - Customers: Single query vs 2N queries (count + random select per order) Results in 30-85% faster batch generation depending on batch size.
layoutd
force-pushed
the
optimize-batch-order-generation
branch
from
0bb12f3 to
5332818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes batch order generation by pre-fetching product, coupon, and customer IDs once per batch instead of querying the database for every single order.
Builds on: #182
Problem
When generating orders in batch, the generator was executing repeated queries for:
For a batch of 100 orders with coupons, this resulted in ~300 database queries.
Solution
Added batch-level caching that pre-fetches all IDs with just 3 queries at the start, then uses array_rand() for random selection throughout the batch.
Performance Impact
Compatibility
Maintains full backward compatibility. Single order generation continues to work as before without using the cache.