Fix refund date constraints to prevent future dates #187

layoutd · 2025-10-28T13:40:16Z

Summary

Prevents refund dates from being set in the future
Ensures second refunds always occur after first refunds
Handles edge cases where time windows are insufficient

Changes

Modified calculate_refund_date() in Order.php:

Added time() checks to cap refund dates at current time
For first refunds: ensures date is between order completion and now (capped at 60 days)
For second refunds: ensures date is between first refund and now (capped at 30 days), with minimum 1-second gap
Added fallback logic for edge cases (e.g., orders completed today)

Technical Details

Before:

First refund: completion_date + random(0-60 days) → could be in future
Second refund: first_refund_date + random(0-30 days) → could be in future

After:

First refund: random(completion_date, min(completion_date + 60 days, now))
Second refund: random(first_refund_date + 1 second, min(first_refund_date + 30 days, now))

Test Plan

Generate orders from this month and verify refunds date/time doesn't exceed current time
wp wc generate orders 10 --date-start=2025-10-01 --status=completed --refund-ratio=1.0
Generate orders with --date-start in the past and verify refund dates are realistic (all in Q1 2025)
wp wc generate orders 10 --date-start=2025-01-01 --date-end=2025-01-31 --status=completed --refund-ratio=1.0
Verify second refunds always have timestamps after first refunds (note they display in reverse order in the UI)

Co-authored-by: Copilot <[email protected]>

…rovided

- Add detailed logging when orders cannot be refunded due to empty line items - Consolidate refund creation error logs into single formatted message - Add error logging for invalid order instance check These improvements will help diagnose why some completed orders aren't receiving refunds when --refund-ratio=1.0 is specified. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Adds check to ensure refund amount is greater than 0 before calling wc_create_refund(). This prevents "Invalid refund amount" errors that occur when: - Orders have 100% discount coupons (total = $0) - Line items have $0 totals - Calculation results in 0 or negative amount Logs order ID, calculated amount, and order total when skipping refund. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

The "Invalid refund amount" error occurred because calculated refund amounts slightly exceeded the available order total due to rounding errors in tax calculations. Changes: - Calculate maximum refundable amount (order total - already refunded) - Cap refund amount to maximum available before calling wc_create_refund() - Round both calculated refund and max refund to 2 decimal places - Improve error logging to show order total and already refunded amounts Example of the issue: - Order total: $24851.03 - Calculated refund (with 3 decimal tax): $24851.04 - Result: $0.01 over limit → "Invalid refund amount" error This fix ensures refunds never exceed the mathematically available amount, preventing WooCommerce validation errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

…partial refunds stay under 50% For full refunds, use the order's actual total instead of summing line items to avoid rounding discrepancies that created tiny 0.01 refunds. For partial refunds, ensure the total stays below 50% of the order total by removing items if needed, preventing two partial refunds from fully refunding an order. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

…over-refunding When creating multiple refunds, the code was using original order quantities instead of accounting for items already refunded. This caused second refunds to exceed the original order quantities (e.g., 11 items refunded from an 8-item order). Now tracks refunded quantities per item and only refunds remaining quantities. All refund logic (full items, partial quantities, and fallback) now calculates remaining quantity = original - already_refunded before processing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

- Add division-by-zero guards before all $original_qty divisions - Change parameter checks from !empty() to isset() to support explicit 0 values - Remove unused variable $removed_item in refund amount calculation These changes improve robustness and prevent potential PHP warnings. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

- First refunds are created within 2 months of order completion date - Second refunds are created within 1 month of first refund date - Update create_refund() to return refund object instead of boolean - Pass previous refund to second refund for proper date calculation This makes generated refund data more realistic for testing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

…percentages using integer rounding

Copilot

Pull Request Overview

This PR refactors the calculate_refund_date method to ensure refund dates are realistic and never occur in the future. The changes prevent edge cases where generated refund dates could exceed the current time or where second refunds could occur before first refunds.

Replaced date-based calculations with timestamp-based logic
Added validation to ensure refund dates never exceed current time
Implemented safeguards to guarantee second refunds always occur after first refunds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

includes/Generator/Order.php

Co-authored-by: Copilot <[email protected]>

…traints

layoutd and others added 30 commits October 23, 2025 01:13

Add --coupon-ratio parameter to order generator

161c802

Add --refund-ratio parameter to order generator

df0fda0

Improve refund logic to properly handle line items and fees

4d3eb9d

Fix refund tax calculation to properly handle tax rate IDs

4dd4a96

Calculate explicit refund amount from line items

84a81bc

Fix refund ratio logic and add multiple refund support

368e5b7

Update partial refund reason to show products and items

479a1a8

Force partial refunds for orders with existing refunds

4f98a67

Recalculate order totals after applying coupon

a3e1536

Update includes/Generator/Order.php

74ae8e1

Co-authored-by: Copilot <[email protected]>

Doc update

e2494ec

Co-authored-by: Copilot <[email protected]>

Fix array_rand edge case for orders with exactly 2 items

ff277e2

Refactor coupon creation to use Coupon::generate()

f80b01e

Move coupon retrieval logic to Coupon::get_random()

ee9ff32

Use WordPress get_posts() API instead of raw SQL queries

07daacb

Add discount_type parameter to Coupon generator

57daab8

Refactor Order generator to use Coupon::batch()

24b2493

Add discount_type parameter to CLI coupon command

f8d718c

Update README with new coupon and order parameters

080ee99

Clarify that refunds are split evenly between partial and full

b9c85f9

Fix backwards compatibility: only set discount_type when explicitly p…

86a499c

…rovided

Add input validation for coupon-ratio and refund-ratio parameters

2c9940e

Add performance comment for get_posts() in Coupon::get_random()

5b53925

Clarify that --coupons flag is equivalent to --coupon-ratio=1.0

0816747

Fix ratio probability calculation using integer-based random generation

0f5dd77

Add check to prevent refunds with empty line items

f69d126

layoutd and others added 9 commits October 24, 2025 16:58

Refactor refund generation: extract constants and helper methods

5734f42

Make default 'fixed_cart' Coupon generator explicit

f08714c

Clarify memory impact

20f415b

Clarify that decimal ratios for coupons and refunds are converted to …

553d847

…percentages using integer rounding

Add error logging for order generation and coupon application failures

e17884b

Prevent future refund dates and ensure second refunds occur after first

152b099

layoutd self-assigned this Oct 28, 2025

layoutd requested a review from Copilot October 29, 2025 23:35

Copilot AI reviewed Oct 29, 2025

View reviewed changes

includes/Generator/Order.php Outdated Show resolved Hide resolved

includes/Generator/Order.php Outdated Show resolved Hide resolved

layoutd and others added 2 commits October 30, 2025 00:44

Update includes/Generator/Order.php

293f57f

Co-authored-by: Copilot <[email protected]>

Update includes/Generator/Order.php

490290c

Co-authored-by: Copilot <[email protected]>

Base automatically changed from add-order-coupon-refund-ratios to trunk October 30, 2025 12:33

Merge remote-tracking branch 'origin/trunk' into fix-refund-date-cons…

52675a0

…traints

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix refund date constraints to prevent future dates #187

Fix refund date constraints to prevent future dates #187

Uh oh!

layoutd commented Oct 28, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix refund date constraints to prevent future dates #187

Are you sure you want to change the base?

Fix refund date constraints to prevent future dates #187

Uh oh!

Conversation

layoutd commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related

Changes

Technical Details

Test Plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

layoutd commented Oct 28, 2025 •

edited

Loading