Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Gallery row with paragraph and button" patterns #17

Merged

Conversation

beafialho
Copy link
Collaborator

Add "Gallery row with paragraph and button" patterns from #5

412013167-dcf10339-94cf-4e31-941a-7c76479bf5fb

Add "Gallery row with paragraph and button" patterns from woocommerce#5
Copy link
Collaborator

@danielwrobert danielwrobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some inline comments below, where the image src URLs need to be changed to point to the assets directory.

<!-- wp:columns {"isStackedOnMobile":false,"align":"wide","style":{"spacing":{"blockGap":{"left":"var:preset|spacing|20"}}}} -->
<div class="wp-block-columns alignwide is-not-stacked-on-mobile"><!-- wp:column {"verticalAlignment":"stretch","width":"25%"} -->
<div class="wp-block-column is-vertically-aligned-stretch" style="flex-basis:25%"><!-- wp:image {"id":331,"aspectRatio":"1","scale":"cover","style":{"color":[]}} -->
<figure class="wp-block-image"><img src="https://kiri.mystagingwebsite.com/wp-content/uploads/2024/12/about-business-image-859x1024.webp" alt="Antique bottles in a dimly lit arched alcove with a textured wall." class="wp-image-331" style="aspect-ratio:1;object-fit:cover"/></figure>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This src attribute needs to be updated to point to the themes assets directory (<?php echo esc_url( get_template_directory_uri() ); ?>/assets/images/about-business-image-859x1024.webp) before merging.


<!-- wp:column {"verticalAlignment":"stretch","width":"25%"} -->
<div class="wp-block-column is-vertically-aligned-stretch" style="flex-basis:25%"><!-- wp:image {"id":493,"aspectRatio":"1","scale":"cover","style":{"color":[]}} -->
<figure class="wp-block-image"><img src="https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-necklace-closeup.jpg" alt="A double-strand turquoise beaded necklace with silver accents." class="wp-image-493" style="aspect-ratio:1;object-fit:cover"/></figure>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.


<!-- wp:column {"verticalAlignment":"stretch","width":"25%"} -->
<div class="wp-block-column is-vertically-aligned-stretch" style="flex-basis:25%"><!-- wp:image {"id":492,"aspectRatio":"1","scale":"cover","style":{"color":[]}} -->
<figure class="wp-block-image"><img src="https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-lamp-closeup.jpg" alt="A close-up of an old metal street lamp with a greenish interior, glowing against a gray background." class="wp-image-492" style="aspect-ratio:1;object-fit:cover"/></figure>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well.


<!-- wp:column {"verticalAlignment":"stretch","width":"25%"} -->
<div class="wp-block-column is-vertically-aligned-stretch" style="flex-basis:25%"><!-- wp:image {"id":491,"aspectRatio":"1","scale":"cover","style":{"color":[]}} -->
<figure class="wp-block-image"><img src="https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-gold-pendant-closeup.jpg" alt="A small, textured gold pendant with a teardrop shape on a white background." class="wp-image-491" style="aspect-ratio:1;object-fit:cover"/></figure>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

@beafialho
Copy link
Collaborator Author

Thank you! I submitted changes according to your comments

Copy link
Collaborator

@danielwrobert danielwrobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🚀

@danielwrobert danielwrobert merged commit 790609a into woocommerce:trunk Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants