-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Two image row, offset text and link" pattern #19
Add "Two image row, offset text and link" pattern #19
Conversation
Add "Two image row, offset text and link" pattern from woocommerce#5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some inline comments below, where the image src
URLs need to be changed to point to the assets directory.
|
||
<!-- wp:columns {"isStackedOnMobile":false,"align":"wide"} --> | ||
<div class="wp-block-columns alignwide is-not-stacked-on-mobile"><!-- wp:column {"width":"70%"} --> | ||
<div class="wp-block-column" style="flex-basis:70%"><!-- wp:cover {"url":"https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-vintage-bracelet.jpg","id":483,"alt":"A vintage silver cuff bracelet with square turquoise stone inlays.","dimRatio":0,"isDark":false,"style":{"color":[]}} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This src
attribute needs to be updated to point to the themes assets directory (<?php echo esc_url( get_template_directory_uri() ); ?>/assets/images/pattern-vintage-bracelet.jpg
) before merging.
<!-- wp:columns {"isStackedOnMobile":false,"align":"wide"} --> | ||
<div class="wp-block-columns alignwide is-not-stacked-on-mobile"><!-- wp:column {"width":"70%"} --> | ||
<div class="wp-block-column" style="flex-basis:70%"><!-- wp:cover {"url":"https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-vintage-bracelet.jpg","id":483,"alt":"A vintage silver cuff bracelet with square turquoise stone inlays.","dimRatio":0,"isDark":false,"style":{"color":[]}} --> | ||
<div class="wp-block-cover is-light"><img class="wp-block-cover__image-background wp-image-483" alt="A vintage silver cuff bracelet with square turquoise stone inlays." src="https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-vintage-bracelet.jpg" data-object-fit="cover"/><span aria-hidden="true" class="wp-block-cover__background has-background-dim-0 has-background-dim"></span><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"align":"center","fontSize":"large"} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
<!-- /wp:column --> | ||
|
||
<!-- wp:column {"width":"30%"} --> | ||
<div class="wp-block-column" style="flex-basis:30%"><!-- wp:cover {"url":"https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-fabric-close-up.jpg","id":453,"alt":"A close-up of loosely woven burlap fabric with a rough texture.","dimRatio":0,"isDark":false,"style":{"color":[]}} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
|
||
<!-- wp:column {"width":"30%"} --> | ||
<div class="wp-block-column" style="flex-basis:30%"><!-- wp:cover {"url":"https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-fabric-close-up.jpg","id":453,"alt":"A close-up of loosely woven burlap fabric with a rough texture.","dimRatio":0,"isDark":false,"style":{"color":[]}} --> | ||
<div class="wp-block-cover is-light"><img class="wp-block-cover__image-background wp-image-453" alt="A close-up of loosely woven burlap fabric with a rough texture." src="https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-fabric-close-up.jpg" data-object-fit="cover"/><span aria-hidden="true" class="wp-block-cover__background has-background-dim-0 has-background-dim"></span><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"align":"center","fontSize":"large"} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well.
Thank you, I submitted the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! 🚀
Add "Two image row, offset text and link" pattern from #5