Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Text, button and two images" patterns #21

Merged

Conversation

beafialho
Copy link
Collaborator

Add "Text, button and two images" patterns from #5

412012319-aad15eae-40d4-4ff1-b3a6-a1b954380fad

Add "Text, button and two images" patterns from woocommerce#5
Copy link
Collaborator

@danielwrobert danielwrobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some inline comments below, where the image src URLs need to be changed to point to the assets directory.

woostarter/patterns/about-text-button-two-images.php Outdated Show resolved Hide resolved
<!-- wp:columns {"align":"wide"} -->
<div class="wp-block-columns alignwide"><!-- wp:column {"width":"%"} -->
<div class="wp-block-column"><!-- wp:cover {"url":"https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-clay-pots-on-a-row-scaled.jpg","id":420,"alt":"A row of rustic clay pots hanging against a woven reed wall.","dimRatio":0,"align":"wide","style":{"color":[]}} -->
<div class="wp-block-cover alignwide"><img class="wp-block-cover__image-background wp-image-420" alt="A row of rustic clay pots hanging against a woven reed wall." src="https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-clay-pots-on-a-row-scaled.jpg" data-object-fit="cover"/><span aria-hidden="true" class="wp-block-cover__background has-background-dim-0 has-background-dim"></span><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"align":"center","fontSize":"large"} -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

<!-- /wp:column -->

<!-- wp:column {"width":"20%"} -->
<div class="wp-block-column" style="flex-basis:20%"><!-- wp:cover {"url":"https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-ceramic-decoration-1024x851.jpg","id":417,"alt":"A stone-like ceramic vessel shaped like a bird with intricate carvings.","dimRatio":0,"focalPoint":{"x":0,"y":1},"isDark":false,"style":{"color":[]}} -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.


<!-- wp:column {"width":"20%"} -->
<div class="wp-block-column" style="flex-basis:20%"><!-- wp:cover {"url":"https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-ceramic-decoration-1024x851.jpg","id":417,"alt":"A stone-like ceramic vessel shaped like a bird with intricate carvings.","dimRatio":0,"focalPoint":{"x":0,"y":1},"isDark":false,"style":{"color":[]}} -->
<div class="wp-block-cover is-light"><img class="wp-block-cover__image-background wp-image-417" alt="A stone-like ceramic vessel shaped like a bird with intricate carvings." src="https://kiri.mystagingwebsite.com/wp-content/uploads/2025/02/pattern-ceramic-decoration-1024x851.jpg" style="object-position:0% 100%" data-object-fit="cover" data-object-position="0% 100%"/><span aria-hidden="true" class="wp-block-cover__background has-background-dim-0 has-background-dim"></span><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"align":"center","fontSize":"large"} -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well.

@beafialho
Copy link
Collaborator Author

Thank you! Submitted the changes

Copy link
Collaborator

@danielwrobert danielwrobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🚀

@danielwrobert danielwrobert merged commit f48c013 into woocommerce:trunk Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants