-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize address #13525
base: 13270-android-sdk-update-target-sdk-to-35
Are you sure you want to change the base?
Normalize address #13525
Conversation
Added a task to remove the bottomsheet from this screen because its unsued GH issue #13507
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
.../com/woocommerce/android/ui/orders/wooshippinglabels/address/WooShippingEditAddressScreen.kt
Fixed
Show fixed
Hide fixed
…material3 # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/themes/ThemePreviewScreen.kt
…ottomsheet-material3' into issue/12439-normalize-address
Project dependencies changesThe following changes in project dependencies were detected (configuration list
tree+\--- androidx.compose.material3:material3-android -> 1.3.0 (*) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 13270-android-sdk-update-target-sdk-to-35 #13525 +/- ##
===============================================================================
+ Coverage 37.94% 37.98% +0.04%
- Complexity 9010 9019 +9
===============================================================================
Files 2054 2056 +2
Lines 112323 112350 +27
Branches 14202 14201 -1
===============================================================================
+ Hits 42620 42680 +60
+ Misses 65814 65778 -36
- Partials 3889 3892 +3 ☔ View full report in Codecov by Sentry. |
…2439-normalize-address
@atorresveiga I noticed that due to this PR dependency and unrelated migrations, the diff is quite big and contains a lot of unrelated changes that make it challenging to understand what this PR introduced in terms of code. Should I wait for the other PR to be merged to start the review here? Or is it fine if I just review the introduced behavior with the test instructions? |
Yes, @ThomazFB let's wait for the dependency PR to get merge 👍 |
Part of: #12439
Description
This PR includes the address normalization logic into the edit origin address flow.
This PR adds:
On top of the above, I also updated the loading UI to include a loading message while the address verification is taking place and some refactors in the view model for simplification. Handling failure will be tackled in the next PR.
Testing information
The tests that have been performed
Images/gif
Screen_recording_20250213_120234.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: