Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Configuration Cache] Disable Configuration Cache on CI (V2) #13546

Draft
wants to merge 11 commits into
base: trunk
Choose a base branch
from

Conversation

ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Feb 13, 2025

Related (Gradle 8.8 & AGP 8.5.1): #13459

Description

This change is primarily about disabling configuration cache (CC) on CI. But, before doing so, we should verify that disabling CC on CI is actually going improve build times, and if not.


Testing information

Testing on Gradle 8.12.1 and AGP 8.8.0 environment:

Job BT (With) BT (Without) BT (Diff) DR - Conf (With) DR - Exec (Without) DR (Diff) TE - Time [Factor] (With) TE - Time [Factor] (Without) TE (Diff)
Mobile App 5m 13s 5m 29s +16s (❌) 2s 2s 0s (☑️) 2m 18s [5.07s] 2m 50s [2.74x] +32s (❌)
Wear App 3m 24s 4m 17s +53s (❌) 1s 1s 0s (☑️) 52s [5.89x] 1m 18s [4.08x] +26s (❌)
Lint App 4m 59s 5m 24s +25s (❌) 3s 2s -1s (✅) 2m 13s [4.78x] 2m 52s [2.43x] +39s (❌)
Unit Tests 7m 37s 5m 54s -1m 43s (✅) 6s 2s -4s (✅) 2m 25s [6.21x] 2m 42s [2.54s] +17s (❌)
UI Tests 10m 53s 12m 33s +2m 40s (❌) 3s 2s -1s (✅) 2m 52s [6.92x] 3m 12s [3.24x] +20s (❌)

Note

  • Without: Without Configuration Cache
  • With: With Configuration Cache
  • BT: Build Time
  • DR: Dependency Resolution -
    • Conf: During configuration
    • Exec: During execution
  • TE: Task Execution
    • Time [Factor]: Time spent executing tasks [Serial execution factor]
Assemble BT (With CC ) BT (Without CC) BT (Diff)
Without BC (Without DC) 19m 30s 22m 17s +47s (❌)
Without BC (With DC) 18m 28s 26m 2s +7m 34s (❌)
With BC (Without DC) 6m 37s 7m 16s +39s (❌)
With BC (With DC)1 5m 8s 6m 4s +56s (❌)

Note

  • CC: Configuration Cache
  • BC: Build Cache
  • DC: Dependency Cache

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

Footnotes

  1. You could also check this x10 build for some aggregate numbers: | BT (With CC ): 4m 55s | BT (Without CC ): 6m 6s |

@ParaskP7 ParaskP7 added status: do not merge Dependent on another PR, ready for review but not ready for merge. category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. Core labels Feb 13, 2025
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 13, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit3eac08e
Direct Downloadwoocommerce-wear-prototype-build-pr13546-3eac08e.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 13, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit3eac08e
Direct Downloadwoocommerce-prototype-build-pr13546-3eac08e.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. Core status: do not merge Dependent on another PR, ready for review but not ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants