Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Woo POS][Design system] Cash, receipt + small adjustments #13555

Open
wants to merge 8 commits into
base: feature-branch-woopos-design-system
Choose a base branch
from
Open

[Woo POS][Design system] Cash, receipt + small adjustments #13555

wants to merge 8 commits into from

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Feb 14, 2025 •
edited by malinajirka
Loading

Closes: #13550

Description

The PR:

  • Makes adjustments to Cash And receipts screens and applies DS to them
  • Changes margins between items in cart and products/variations

1qcjzXitBHU7xPnpCOWnNM-fi-1282_12984

Testing information

  • User dark and light mode
  • Validate that the changed screens follows Figma designs

The tests that have been performed

Images/gif

image image image image
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 14, 2025 •
edited
Loading

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitf15c68f
Direct Downloadwoocommerce-wear-prototype-build-pr13555-f15c68f.apk

@kidinov kidinov added the category: design Layout and style elements in the UI or user interface, including color and animations. label Feb 14, 2025
@kidinov kidinov mentioned this pull request Feb 14, 2025
Open
8 tasks
@kidinov kidinov added the feature: point of sale POS project label Feb 14, 2025
@kidinov kidinov added this to the 21.8 milestone Feb 14, 2025
@kidinov
Merge branch 'feature-branch-woopos-design-system' into 13550-woo-pos…
f15c68f 
…design-system-apply-pos-ds-colors-to-the-cash-screen

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/cashpayment/WooPosCashPaymentScreen.kt
@kidinov kidinov requested a review from malinajirka February 14, 2025 09:02
@malinajirka malinajirka self-assigned this Feb 14, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitf15c68f
Direct Downloadwoocommerce-prototype-build-pr13555-f15c68f.apk

malinajirka
malinajirka requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kidinov! This look good overall, I just noticed the background color is off - #F6F7F7 vs #FDF7FE.

@kidinov
Copy link
Contributor Author

kidinov commented Feb 14, 2025

@malinajirka 👋

Could you please clarify the background of what that is? What screen? Where FDF7FE comes from - it's not in the pallete, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malinajirka malinajirka malinajirka requested changes

Assignees

@malinajirka malinajirka

Labels
category: design Layout and style elements in the UI or user interface, including color and animations. feature: point of sale POS project
Projects
None yet
Milestone
21.8
Development

Successfully merging this pull request may close these issues.
3 participants
@kidinov @wpmobilebot @malinajirka