Make sure product exists before using it in ajax response #3687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WC_Stripe_Payment_Request::ajax_add_to_cart()
function takes a product ID from the request body and passes it to wc_get_product(). That function will return null if the product is not found, and false if the function call happened out of order (that is, before some prerequisite hooks have run).Currently we're assuming that the product lookup succeeded, but if it doesn't then the
$product->get_type()
call on the following line raises a critical error likeUncaught Error: Call to a member function get_type() on bool
.changelog.txt
andreadme.txt
(or does not apply)Post merge