Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing express methods constants #3845

Open
wants to merge 3 commits into
base: dev/improving-handling-of-ece-method-titles
Choose a base branch
from

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Feb 5, 2025

Changes proposed in this Pull Request:

This PR introduces new constants for the express payment methods (Google Pay, Apple Pay, Link and Amazon Pay) on the backend. And also implements them on the codebase.

Testing instructions

Code review should be enough. Check if the tests are still passing.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@wjrosa wjrosa self-assigned this Feb 5, 2025
@wjrosa wjrosa marked this pull request as ready for review February 6, 2025 12:51
@wjrosa wjrosa requested review from a team and diegocurbelo and removed request for a team February 6, 2025 13:04
Copy link
Member

@diegocurbelo diegocurbelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants