Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the method checking for the subscription extension status to a new helper class #3864

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Feb 10, 2025

Changes proposed in this Pull Request:

This is a simple PR that moves the is_subscriptions_enabled method to a new helper class (WC_Stripe_Subscriptions_Helper). This will allow us to check for the extension status on any non-gateway classes, avoiding the need of using the WC_Stripe_Subscriptions_Utilities_Trait trait.

Testing instructions

Code review. Check if the tests are still passing.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@wjrosa wjrosa self-assigned this Feb 10, 2025
Base automatically changed from add/admin-notices-for-detached-subscriptions to develop February 11, 2025 21:53
@wjrosa wjrosa marked this pull request as ready for review February 13, 2025 12:26
@wjrosa wjrosa requested a review from diegocurbelo February 13, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant