Skip to content

Add back failing test to run it on CI #15220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

Add back failing test to run it on CI #15220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6eac49
Add back failing test to run it on CI
iangmaia Feb 20, 2025
0bf07e8
Force failure
iangmaia Feb 20, 2025
b585579
Update to latest fastlane
AliSoftware Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ gem 'cocoapods-catalyst-support', '~> 0.1'
gem 'danger-dangermattic', '~> 1.2'
gem 'dotenv'
# 2.217.0 includes a fix for Xcode 15 test results parsing in CI
gem 'fastlane', '~> 2.217'
gem 'fastlane', '~> 2.227'
gem 'fastlane-plugin-appcenter', '~> 2.0'
gem 'fastlane-plugin-sentry', '~> 1.0'
# This comment avoids typing to switch to a development version for testing.
Expand Down
25 changes: 13 additions & 12 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,22 @@ GEM
artifactory (3.0.17)
ast (2.4.2)
atomos (0.1.3)
aws-eventstream (1.3.0)
aws-partitions (1.1029.0)
aws-sdk-core (3.214.1)
aws-eventstream (1.3.2)
aws-partitions (1.1065.0)
aws-sdk-core (3.220.1)
aws-eventstream (~> 1, >= 1.3.0)
aws-partitions (~> 1, >= 1.992.0)
aws-sigv4 (~> 1.9)
base64
jmespath (~> 1, >= 1.6.1)
aws-sdk-kms (1.96.0)
aws-sdk-core (~> 3, >= 3.210.0)
aws-sdk-kms (1.99.0)
aws-sdk-core (~> 3, >= 3.216.0)
aws-sigv4 (~> 1.5)
aws-sdk-s3 (1.176.1)
aws-sdk-core (~> 3, >= 3.210.0)
aws-sdk-s3 (1.182.0)
aws-sdk-core (~> 3, >= 3.216.0)
aws-sdk-kms (~> 1)
aws-sigv4 (~> 1.5)
aws-sigv4 (1.10.1)
aws-sigv4 (1.11.0)
aws-eventstream (~> 1, >= 1.0.2)
babosa (1.0.4)
base64 (0.2.0)
Expand Down Expand Up @@ -167,8 +168,8 @@ GEM
faraday-retry (1.0.3)
faraday_middleware (1.2.1)
faraday (~> 1.0)
fastimage (2.3.1)
fastlane (2.226.0)
fastimage (2.4.0)
fastlane (2.227.0)
CFPropertyList (>= 2.3, < 4.0.0)
addressable (>= 2.8, < 3.0.0)
artifactory (~> 3.0)
Expand Down Expand Up @@ -359,7 +360,7 @@ GEM
ruby-macho (2.5.1)
ruby-progressbar (1.13.0)
ruby2_keywords (0.0.5)
rubyzip (2.3.2)
rubyzip (2.4.1)
sawyer (0.9.2)
addressable (>= 2.3.5)
faraday (>= 0.17.3, < 3)
Expand Down Expand Up @@ -415,7 +416,7 @@ DEPENDENCIES
cocoapods-catalyst-support (~> 0.1)
danger-dangermattic (~> 1.2)
dotenv
fastlane (~> 2.217)
fastlane (~> 2.227)
fastlane-plugin-appcenter (~> 2.0)
fastlane-plugin-sentry (~> 1.0)
fastlane-plugin-wpmreleasetoolkit (~> 12.5)
Expand Down
21 changes: 21 additions & 0 deletions WooCommerce/WooCommerceTests/POS/Models/PointOfSaleAggregateModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ struct PointOfSaleAggregateModelTests {
collectOrderPaymentAnalyticsTracker: MockPOSCollectOrderPaymentAnalyticsTracker())
// Then
#expect(sut.orderStage == .building)

// Then
#expect(sut.orderStage != .building)
}

@available(iOS 17.0, *)
Expand Down Expand Up @@ -166,6 +169,24 @@ struct PointOfSaleAggregateModelTests {
#expect(sut.cart.isEmpty)
}

@available(iOS 17.0, *)
@Test func removeAllItemsFromCart_when_tapped_then_tracks_event() {
// Given
let sut = PointOfSaleAggregateModel(
itemsController: MockPointOfSaleItemsController(),
cardPresentPaymentService: MockCardPresentPaymentService(),
orderController: MockPointOfSaleOrderController(),
analytics: analytics,
collectOrderPaymentAnalyticsTracker: MockPOSCollectOrderPaymentAnalyticsTracker()
)

//When
sut.removeAllItemsFromCart()

// Then
#expect(analyticsProvider.receivedEvents.first(where: { $0 == "clear_cart_tapped" }) != nil)
}

@available(iOS 17.0, *)
@Test(.disabled(
"""
Expand Down