Skip to content

Deintegrate CocoaPods #15669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented May 26, 2025

Description

  • Delete Podfile and remove the Pods project from the workspace
  • Updated Rakefile to no longer install CocoaPods
  • Update Fastfile to use Module/Sources for the localization now in
    SwiftPM
  • Remove CocoaPods caching from CI

Steps to reproduce & Testing information

See green CI and run on device.

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

dangermattic commented May 26, 2025

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 26, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30103
VersionPR #15669
Bundle IDcom.automattic.alpha.woocommerce
Commit7c35246
Installation URL0p3bi7ttvvn48
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio mokagio added this to the 22.6 milestone May 26, 2025
@mokagio mokagio added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label May 26, 2025
@mokagio mokagio self-assigned this May 26, 2025
@mokagio mokagio force-pushed the ainfra-619-remove-cocoapods-from-the-workspace branch 3 times, most recently from 7af14b6 to 25db581 Compare May 27, 2025 10:05
- Delete `Podfile` and remove the Pods project from the workspace
- Updated `Rakefile` to no longer install CocoaPods
- Update `Fastfile` to use `Module/Sources` for the localization now in
  SwiftPM
- Remove CocoaPods caching from CI
@mokagio mokagio force-pushed the ainfra-619-remove-cocoapods-from-the-workspace branch from 25db581 to 9c87b4a Compare May 27, 2025 20:29
@mokagio mokagio marked this pull request as ready for review May 27, 2025 21:10
@mokagio mokagio enabled auto-merge May 27, 2025 21:11
@@ -22,9 +22,6 @@ steps:

echo '--- :snowflake: Start Code Freeze'
bundle exec fastlane start_code_freeze skip_confirm:true

echo '--- :cocoapods: Check for Outdated Pods'
.buildkite/commands/log-outdated-pods.sh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This well need to be followed up with an update on the Releases v2 app to remove the CocoaPods mentions there, too.

@mokagio mokagio requested review from a team May 27, 2025 21:36
@iamgabrielma iamgabrielma self-assigned this May 29, 2025
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tests pass, works well, and runs normally both in simulator and physical devices.

I'm unsure if is just part of the process, but every time I close the simulator it crashes in main, not much of a stack trace to follow thought, just a crash 100% of the times. It has happen before and then stopped for no reason as well, so could be entirely my machine (using Xcode 16.2)

Screenshot 2025-05-29 at 09 38 44

@mokagio mokagio merged commit 9dbb5f2 into trunk May 29, 2025
13 checks passed
@mokagio mokagio deleted the ainfra-619-remove-cocoapods-from-the-workspace branch May 29, 2025 03:02
@mokagio
Copy link
Contributor Author

mokagio commented May 29, 2025

Thanks for testing and for the review @iamgabrielma !

every time I close the simulator it crashes in main

Never seen it, but I don't use the app much past launching it and tapping around a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants