-
Notifications
You must be signed in to change notification settings - Fork 116
[Woo POS][Product Labels] Display stock levels for variations #15676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
[Woo POS][Product Labels] Display stock levels for variations #15676
Conversation
@@ -18,15 +28,38 @@ struct POSStockFormatter { | |||
} | |||
} | |||
|
|||
private static func label(for key: String) -> String { | |||
switch key { | |||
case "instock": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StockStatusKey
happens to be in Networking at the moment, so we cannot use it directly in this target. I'll update the usage from String to an enum with WOOMOB-517 when testing/handling undocumented stock statuses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we can, not sure why Xcode was not finding it on a first go, as I can see the typealias it in Yosemite and compiles if I switch it despite the warnings.
|
No need to review this one for the moment @staskus as we might need to move this project for the time being. I'll switch it back to draft for now, and close it in a few days if we go ahead with the decision 👍 |
Version |
Closes WOOMOB-495
Description
As continuation of #15647 , this PR adapts the
POSVariation
model to usemanageStock
,stockQuantity
, andstockStatusKey
properties. As well as render them on the view (final UI TBD)Testing
inventoryProductLabelsInPOS
is disabled we shouldn't see any changes in the variation cardsRELEASE-NOTES.txt
if necessary.