Skip to content

Shipping Label: Handle payment method selection #15684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: woomob-434-payment-update-the-payment-method-sheet-with-existing
Choose a base branch
from

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented May 29, 2025

Closes WOOMOB-527

Description

This PR integrates the account setting update API endpoint to handle payment method selection. Changes include:

  • Networking: Updated WooShippingRemote with a new method for updating account settings.
  • Yosemite: Updated WooShippingAction and WooShippingStore`.
  • UI: handled the action upon tapping the Use this card button.

Testing steps

  1. Log in to a test store with Woo Shipping plugin set up.
  2. Navigate to the Orders tab and select a paid order with physcial products and unfulfilled shipments.
  3. If your store already has no payment methods set up, follow the guide in PbTz5e-gi-p2 to add more than 1 test payment method in the sandbox mode.
  4. Select Create shipping label > Expand the Shipment details bottom sheet > select the payment method section.
  5. Select a payment method different from the selected method and/or toggle the email receipt switch.
  6. Tap Use this card and confirm:
  • If the request succeeds, the payment method sheet should be dismissed, and the correct payment method section is display in the Shipment detail sheet. Tapping on the payment method section again, the presented sheet should display the updated settings.
  • If the request fails, an alert should be displayed with an option to retry.

Testing information

Tested and confirmed with simulator iPhone 16 iOS 18.4

Screenshots

Simulator.Screen.Recording.-.iPhone.16.-.2025-05-30.at.17.50.02.mp4

Error state:


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 22.6 milestone May 29, 2025
@itsmeichigo itsmeichigo added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels May 29, 2025
@itsmeichigo itsmeichigo changed the title Woomob 527 payment integrate api endpoint to save account settings Shipping Label: Handle payment method selection May 29, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 29, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30175
VersionPR #15684
Bundle IDcom.automattic.alpha.woocommerce
Commit64abc9e
Installation URL3q0g6u9gdsti8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review May 30, 2025 11:04
@itsmeichigo itsmeichigo requested a review from RafaelKayumov May 30, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants