Skip to content

Update duplicated string identifier and re-enable failing test #15699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

Update duplicated string identifier and re-enable failing test #15699

merged 1 commit into from
Jun 2, 2025

Conversation

iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Jun 2, 2025 •
edited
Loading

Description

This test updates the duplicated string pos.stockStatusLabel.outofstock identifier and re-enables the test we disabled on p1748592083887729-slack-CC7L49W13 in order to unblock 22.5 code freeze.

The string usage is behind a feature flag and not currently visible.

Testing information

CI should pass.

@iamgabrielma iamgabrielma added this to the 22.6 milestone Jun 2, 2025
@iamgabrielma iamgabrielma added type: bug A confirmed bug. type: task An internally driven task. feature: product details Related to adding or editing products, including Product Settings. labels Jun 2, 2025
@iamgabrielma iamgabrielma requested a review from itsmeichigo June 2, 2025 05:20
@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30202
VersionPR #15699
Bundle IDcom.automattic.alpha.woocommerce
Commitbc400e2
Installation URL7svq0djakhh8o
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo self-assigned this Jun 2, 2025
itsmeichigo
itsmeichigo approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@iamgabrielma iamgabrielma merged commit 123a64e into trunk Jun 2, 2025
24 of 27 checks passed
@iamgabrielma iamgabrielma deleted the task/update-duplicated-string branch June 2, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

Assignees

@itsmeichigo itsmeichigo

Labels
feature: product details Related to adding or editing products, including Product Settings. type: bug A confirmed bug. type: task An internally driven task.
Projects
None yet
Milestone
22.6
Development

Successfully merging this pull request may close these issues.
3 participants
@iamgabrielma @wpmobilebot @itsmeichigo