Skip to content

Fix PDF Credit Note Generation Crash by WC_Order check #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Fix PDF Credit Note Generation Crash by WC_Order check #411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d668b3
Fix PDF Credit Note Generation Crash by `WC_Order` check
faisal-alvi Sep 25, 2025
c65e739
Merge branch 'trunk' into SQUARE-180
dkotter Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions includes/Handlers/Order.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,11 @@ public function filter_gateway_title( $value, $id ) {
* @return array
*/
public function filter_order_item_totals( $total_rows, $order ) {
// Ensure $order is an instance of WC_Order before calling get_payment_method().
if ( ! $order instanceof \WC_Order ) {
return $total_rows;
}

$charge_type = wc_square()->get_gateway( $order->get_payment_method() )->get_order_meta( $order, 'charge_type' );

if ( Payment_Gateway::CHARGE_TYPE_PARTIAL !== $charge_type ) {
Expand Down