Fixing scroll #21847
Open
Fixing scroll #21847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue described in #21169 involved the playback speed menu of an audio block scrolling along with the background page. This happened because the menu's scroll behavior was incorrectly tied to the page's scroll.
To resolve this, we only needed to modify a single file:
WordPress/src/main/java/org/wordpress/android/widgets/NestedWebView.kt.In this file, the
isNestingScrollEnabledvariable was initially set totrue, which caused the playback speed menu to scroll together with the page content. As a result, when users tried to scroll through the speed options, the entire page would scroll instead.By addressing this configuration, we decoupled the menu's scroll behavior from the parent view, allowing the playback speed options to scroll independently as expected.
Testing instructions
closes #21169