Skip to content

Convert ImageSizeMap to Kotlin #21888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 67 commits into from
May 19, 2025
Merged

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented May 16, 2025

Closes CMM-351

This PR converts ImageSizeMap to Kotlin and addresses various nullability issues. I probably could've done this as part of #21877 but that was already quite large so I opted to handle it separately.

The purpose of this class is to store a hashmap of normalized image urls and their sizes. This is used by ReaderPostRenderer when laying out images.

To test, smoke test the Reader and verify that images appear as expected (or, at least, appear the same as they do in trunk).

Copilot

This comment was marked as outdated.

@dangermattic
Copy link
Collaborator

dangermattic commented May 16, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 16, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21888-56b4f9d
Commit56b4f9d
Direct Downloadjetpack-prototype-build-pr21888-56b4f9d.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 16, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21888-56b4f9d
Commit56b4f9d
Direct Downloadwordpress-prototype-build-pr21888-56b4f9d.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.63%. Comparing base (d64be53) to head (56b4f9d).
Report is 1 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #21888      +/-   ##
==========================================
+ Coverage   39.62%   39.63%   +0.01%     
==========================================
  Files        2125     2124       -1     
  Lines       99254    99218      -36     
  Branches    15253    15243      -10     
==========================================
  Hits        39330    39330              
+ Misses      56463    56427      -36     
  Partials     3461     3461              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nbradbury nbradbury marked this pull request as ready for review May 16, 2025 15:19
@nbradbury nbradbury requested a review from adalpari May 16, 2025 15:20
Copy link
Contributor

@adalpari adalpari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nbradbury nbradbury enabled auto-merge (squash) May 19, 2025 11:48
@nbradbury nbradbury merged commit b2a4639 into trunk May 19, 2025
26 checks passed
@nbradbury nbradbury deleted the issue/CMM-351-reader-imagesizemap branch May 19, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants