-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Convert ImageSizeMap to Kotlin #21888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n' into issue/CMM-351-reader-utils-kotlin
Generated by 🚫 Danger |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21888-56b4f9d | |
Commit | 56b4f9d | |
Direct Download | jetpack-prototype-build-pr21888-56b4f9d.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21888-56b4f9d | |
Commit | 56b4f9d | |
Direct Download | wordpress-prototype-build-pr21888-56b4f9d.apk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #21888 +/- ##
==========================================
+ Coverage 39.62% 39.63% +0.01%
==========================================
Files 2125 2124 -1
Lines 99254 99218 -36
Branches 15253 15243 -10
==========================================
Hits 39330 39330
+ Misses 56463 56427 -36
Partials 3461 3461 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes CMM-351
This PR converts
ImageSizeMap
to Kotlin and addresses various nullability issues. I probably could've done this as part of #21877 but that was already quite large so I opted to handle it separately.The purpose of this class is to store a hashmap of normalized image urls and their sizes. This is used by
ReaderPostRenderer
when laying out images.To test, smoke test the Reader and verify that images appear as expected (or, at least, appear the same as they do in
trunk
).