Fix crash in RawBlockEditorSettingsService

[kean]

Fixes https://a8c.sentry.io/issues/6942573624/
Closes https://linear.app/a8c/issue/CMM-838/exc-breakpoint-release

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	29665
	Version	PR #24944
	Bundle ID	org.wordpress.alpha
	Commit	cb01548
	Installation URL	3h1c3uvm5grbo

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	29665
	Version	PR #24944
	Bundle ID	com.jetpack.alpha
	Commit	cb01548
	Installation URL	0nh03caamn4c8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[jkmassel]

Can we find out why WordPressOrgRestApi might not be initializable? There shouldn't be any blogs on the device that don't work with this, so if there are we should figure out why – we probably have the data we need, we're just not getting it in the right way.

[kean]

It looks like it's normal situation for the init to return nil as it requires authorization to be present. For Dotcom blog, the token can be nil if it's invalidated by the server. For Dotorg blogs, it's a bit more complicated – any of these five fields can be missing. I'm not familiar with this code, but it seems reasonable from the first glance.

Regardless of the reason it returns nil, the code in this PR should not force-unwrap it and should fail gracefully. Presumably, there is another part of system that will handle the missing authorization or other missing fields.

The crash only affected one user: https://a8c.sentry.io/issues/6942573624/events/?project=5716771. It's like a self-hosted site due to the missing "user" field.

[jkmassel]

Could we have RawBlockEditorSettingsService take WordPressOrgRestApi as a non-optional initializer then?

That way we can at least make it so that class doesn't need special error handling?

[dangermattic]

	1 Message
📖	This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

[kean]

Could we have RawBlockEditorSettingsService take WordPressOrgRestApi as a non-optional initializer then?

I'm not sure if that's exactly what you want. Currently, RawBlockEditorSettingsService deals with an optional. If it doesn't, every place that uses it will need to. I pushed a commit with this change cb01548 let me know if you want to keep it.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud