Various clean-ups and configuration improvements #489
Conversation
|
@wordpress-mobile/apps-infrastructure -- during my trial, at some point we've created this "base branch" for merging some of the PRs I created so that we could review and approve them quicker, because back then we were not yet ready for some of the breaking changes to land and block a major release. |
| @@ -13,14 +13,14 @@ | |||
| expect_build_number(xcconfig_mock_content: xcconfig_mock_content, expected_build_number: '1940') | |||
| end | |||
|
|
|||
| it 'parses an xcconfig file with keys with spaces and returns a nil build number' do | |||
| it 'parses an xcconfig file with keys with spaces and returns the correct build number' do | |||
There was a problem hiding this comment.
This test was verifying something else given we didn't use xcodeproj for parsing the .xcconfig file (see this comment from @spencertransier).
There was a problem hiding this comment.
Awesome, thanks for updating this test @iangmaia!
There was a problem hiding this comment.
These changes all look great @iangmaia. Thanks for your awesome work during your trial! 👏
lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_version_helper.rb
Outdated
Show resolved
Hide resolved
We now have newer, better actions to achieve the same results: - `ios_generate_strings_file_from_code` - `ios_extract_keys_from_strings_files` - `ios_download_strings_files_from_glotpress` - `ios_merge_strings_files`
Co-authored-by: Olivier Halligon <[email protected]>
…o that the same name can be reused across actions
Co-authored-by: Olivier Halligon <[email protected]>
…to avoid relying on implementation details
…d of manually parsing it
lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_version_helper.rb
Outdated
Show resolved
Hide resolved
What does it do?
It contains the changes implemented in the following Pull Requests:
ios_get_app_version#445ios_get_app_version#451Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicablebundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the approprioate existing###subsection of the existing## Trunksection.