-
Notifications
You must be signed in to change notification settings - Fork 20
Llm integration POC #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Llm integration POC #1028
Conversation
…s allowed token count. Make conflicting libraries pydantic-ai and ag-ui optional; disabling agent route if not installed. Make search routes async and fix small bugs in query building.
CodSpeed Performance ReportMerging #1028 will not alter performanceComparing 🎉 Hooray!
|
…hestrator-core into llm-integration
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
==========================================
- Coverage 84.93% 80.22% -4.72%
==========================================
Files 214 245 +31
Lines 10408 11821 +1413
Branches 1020 1161 +141
==========================================
+ Hits 8840 9483 +643
- Misses 1295 2082 +787
+ Partials 273 256 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dotenv run python main.py search semantic "Shop for an alligator store" | ||
... | ||
{ | ||
"path": "subscription.shop.shop_description", | ||
"value": "Kingswood reptiles shop" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make the examples more generic (also the ones below), since this is specific for the WFO instance where we built the initial POC.
...migrations/versions/schema/2025-08-12_52b37b5b2714_search_index_model_for_llm_integration.py
Outdated
Show resolved
Hide resolved
### Step back to the revision right before the dynamic-dimension migration | ||
|
||
```bash | ||
dotenv run python main.py db downgrade 850dccac3b02 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented before that we needed a script for this, but does this mean you can run this migration independent from all other migrations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you can downgrade a specific migration and upgrade it again, essentially achieving the same as a cli script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SURF doesn't have a downgrade policy: often they are written: but not always. (also no tests).
If stuff breaks in production -> we try to move forwards.
orchestrator/search/filters/base.py
Outdated
FilterCondition = ( | ||
DateFilter # DATETIME | ||
| NumericFilter # INT/FLOAT | ||
| StringFilter # STRING TODO: convert to hybrid search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to make a ticket for this TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im thinking that maybe this stringfilter should be removed altogether, its already possible to do a hybrid search by passing a user query, passing something like the top 5 results back to the agent will probably yield better results.
For things like booleans/product blocks , we already have the equality filter. Matching on exact text by letting the agent fill in a string will probably not work well.
…ndpoints for autocompleting paths and UI compatible operators per field type for frontend rendering.
… settings and instructions.
…ption records in response, improve highlighting
…hestrator-core into llm-integration
pydantic-ai
andag-ui-protocol
need
pydantic >= 2.10
and>=2.11.2
respectively, this breaks some of the unit tests