Add 2d anon stats opposite mirror batch config - #136
Merged
gryaele merged 2 commits intoAug 5, 2026
Merged
Conversation
carlomazzaferro
approved these changes
Aug 5, 2026
gryaele
deleted the
elenagryaznova/pop-4221-configure-bucket-size-of-20-for-the-di-stats-opposite-mirror
branch
August 5, 2026 08:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new configuration option for 2D anonymous statistics computation specifically for the "opposite mirror match" case. It also defines a default value for this new parameter to ensure consistent behavior when the value is not explicitly set.
Configuration Enhancements:
min_2d_job_size_opposite_mirror_matchto theAnonStatsServerConfigstruct to control the minimum job size for 2D anon stats computation in the "opposite mirror match" scenario. This allows for more granular configuration and potentially improved performance for this specific case.default_min_2d_job_size_opposite_mirror_matchreturning20, ensuring the new config field has a sensible default if not specified.