feat: accept Laissez-Passer attestation tokens without JTI binding - #230
Closed
orekav wants to merge 1 commit into
Closed
feat: accept Laissez-Passer attestation tokens without JTI binding#230orekav wants to merge 1 commit into
orekav wants to merge 1 commit into
Conversation
Match app-backend-risk by skipping request-hash validation for AG tokens with check_type=dev so LP users are not rejected with attestation-failure.
orekav
requested review from
aurel-fr,
murph,
paolodamico and
thomas-waite
as code owners
August 4, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_type: "dev") without requiringjtito match the request hash, matching app-backend-risk.pass, expiry, issuer, and audience checks; OSV tokens still require a matchingjti.attestation-failure: JTI claim (request hash) is not validon gated backup endpoints (e.g./v1/retrieve/from-challenge) while enforcement is soft-disabled.Test plan
cargo test --lib laissez_passercargo test --lib test_validate_token_osv_still_requires_jticheck_type=dev) request to/v1/retrieve/from-challengereturns 200 withoutattestation-failureheaderjtimismatches#227/0.9.5path-hash fix is deployed alongside this for non-LP clients