feat(portal-v3): integrator golden path — wave 1 redesign - #2079
Draft
soamdesai-tfh wants to merge 32 commits into
Draft
feat(portal-v3): integrator golden path — wave 1 redesign#2079soamdesai-tfh wants to merge 32 commits into
soamdesai-tfh wants to merge 32 commits into
Conversation
…ini App / Legacy actions
…e coverage for auto team
… save-your-key step
…y dismissal, bounded registration timeout
Moves the hardened keygen+registerRp sequence (once-per-app signer key, 30s AbortController timeout, already_registered treated as success, posthog capture with no key leakage) into a standalone hook so the dashboard setup strip can reuse it for existing-app RP recovery. The dialog now consumes the hook via a status->step mapping; behavior is unchanged (8/8 tests in pv3-w1-create-app-auto-rp.test.tsx pass unmodified).
…A, live first-proof wait Adds SetupStrip above VerificationStatusSection, replacing WorldId40MigrationBanner in v3. Renders exactly one of: RP-missing recovery (reusing use-auto-register-rp, with an admin-only gate and an inline save-your-key panel), a create-first-action CTA once RP is registered, a polling live-wait for the first verification once actions exist, or nothing once real verification traffic shows up. Polling (via startPolling/stopPolling) is scoped to the waiting state only, and the first-proof posthog capture fires exactly once per live 0->1 crossing (a fresh mount that arrives already-verified does not re-trigger it).
…d payments/metrics calls
…ippet defines
The frontend snippet was posting to /api/v4/verify/${appId} on the developer's own origin, but the backend snippet defines the route at /api/verify-world-id. Developers pasting the two snippets together would get a 404. Changed the frontend fetch URL to match the backend route exactly.
…human" This reverts commit 6330cf0ff8968a32bce47c5a1ef60ca42f986d92.
Move the apps welcome page's InitialApp query from scenes/Portal into scenes/common so the v3 fork can share it without importing scenes/Portal.
…copy Fork the /teams/[teamId]/apps welcome page into PortalV3 with new verify-your-first-human copy, and flip the route to choose between v2 and v3 via pickPortalVersion, following the phase-1 migration recipe.
…ia the shared atom
…te-team login-callback sends brand-new users to /create-team before they ever reach the portal shell, so the shell-mounted AutoTeamBootstrap was unreachable on the actual first-login path (caught in manual walkthrough). The route now chooses per user: v3 new users get the auto-created personal team; users who already have a team (intentionally creating another) keep the manual form; v2 unchanged.
…, email-aware team names - deriveTeamName moved out of the 'use client' module (calling it from the create-team server page threw a client-reference error; the layout call site had the same latent bug, masked by unreachability) - AutoTeamBootstrap recovers from lost create races (concurrent tab already made the team → re-read profile → proceed) instead of showing the error card - email signups no longer get 'foo@bar.com's team' (name===email falls back to the local-part)
…t froze it on the pre-action answer
…next to the integration snippet The live 'waiting → ✓ first proof received' indicator lived on the app dashboard, disconnected from where the developer just did the work — a context-free banner. Relocate it onto the action page beside the Quickstart: it polls while the action has zero verifications and flips in place the instant one lands, right next to the IDKit snippet / simulator link they used. The dashboard SetupStrip is trimmed to pure setup guidance (RP recovery + create-first-action); the funnel event moves with the moment (now keyed by action_id).
The post-create soft navigation could read a stale (team-less) session and bounce back to /create-team, re-firing the auto-create and colliding on the duplicate-user constraint — surfacing an error card over an account that was actually created. Hard-navigate (window.location) so the server sees the fresh session cookie and no bounce occurs; on any create failure, refresh the session and poll the profile before giving up, recovering into the existing team rather than showing the error.
…tart dropdown; remove waiting indicator
…n; drop first-proof test
…t + Settings-tab tester The left-column Verifications count duplicated the Verified-humans count beside it, and the Settings tab's Try-it-out tester duplicated the QR tester now on the Overview page — remove both. Settings becomes a single-column identifier/ description form; the Overview page owns the tester.
… cookie probe actually recovers
The action Overview page's Try-it-out tester and the Show-integration- quickstart dropdown both rendered near-identical IDKit code. Add an optional kioskOnly prop to TryAction that hides the code view and the view-toggle when the QR kiosk is available, and pass it from the Overview page so the quickstart dropdown is the single source of integration code. The code view still shows as a fallback for app types without a kiosk (e.g. on-chain), and all other TryAction usages are unchanged (default off).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wave 1 of the v3 portal redesign: an integrator-first golden path for the developer adding World ID to their app (proof-of-personhood via World ID 4.0), distinct from the miniapp-builder flow. Entirely behind the per-email
PORTAL_V3_EMAILSflag — v2 users see no change.The path: sign up → auto-created personal team (no team ceremony) → onboarding ("Verify your first human") → create app (auto-registers the RP with a managed signer key, one save-your-key step) → create an action → embedded IDKit quickstart → watch the first verified proof arrive on the dashboard.
Pieces (8 tasks)
useAppCapabilitieshook → sidebar showsDashboard · Actions · Sign in · Configuration · Advanced;Mini AppandLegacy actionsappear only for apps that have them. The old "World ID" item is replaced by "Advanced"./api/create-team(no backend change); fails loud to the manual create-team page.create → registering → key-ready → register-failed. Shareduse-auto-register-rphook.IDKitRequestWidgetsnippet, staging → Simulator link)./create-teamforked + flipped — the route login-callback sends brand-new users to; v3 users get the auto-team there (caught in manual walkthrough: the shell-mounted bootstrap was unreachable on the real signup path), second-team creation keeps the manual form.Constraints held
@/scenes/PortalV3 → @/scenes/Portalimports (decoupling invariant preserved).scenes/Portal) untouched except one import-repoint from a GraphQL-doc drain (apps-page doc →scenes/common, R100 rename)..graphql/codegen;web/graphql/graphql.tsuntouched.Verification
npx tsc --noEmit→ 0 ·npx jest tests/unit/→ 57 suites / 172 tests pass ·pnpmprettier clean on all touched files.Not yet done — needs a human
PORTAL_V3_EMAILSaccount before merge: fresh user → auto-team → onboarding → click Start → create app → save key → dashboard → create action → quickstart → (staging) produce a Simulator proof → strip flips to ✓.Known follow-ups (not blockers)
WorldId40MigrationBanneris now orphaned (SetupStrip superseded it); its?enableWorldId4link is benign self-navigation. Left in place per surgical-change discipline; remove in a later wave.v3_*events are emitted by the components but not yet dashboarded/alerted.Rollout / rollback
Per-user via
PORTAL_V3_EMAILS; nothing ships to non-allow-listed users. Rollback = revert the merge; v2 paths are untouched.