fix(portal): preload profile menu icons - #2224
Merged
Merged
Conversation
Preload account and switcher icons at render time so first open isn't blank, and drop the idle/hover preload machinery. Co-authored-by: Cursor <cursoragent@cursor.com>
…rldcoin/developer-portal into kartike/preload-icons-eagerly
igorosip0v
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Description
Preloaded all icons. Icons inside switchers get preloaded on when their component renders.
Why
Icons in menus/switchers/lists would appear blank for some time as they wouldn't be fetched until the user opened their component. Not clean UX, so we preloaded the icons that a component uses when it mounts on its parent layout
Checklist