genesis: remove the unused post-run snapshot phase - #2317
Draft
mcalancea wants to merge 1 commit into
Draft
Conversation
The RDS cluster-snapshot phase has only ever been dispatched with perform_snapshot=false, so the flag, the phase and the RDS client are dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Genesis had an optional phase 3 that created an RDS cluster snapshot after indexation. The
--perform-snapshotflag has only ever been passed asfalse, so the phase is unreachable in practice; this removes the flag, the phase, and the RDS client that existed solely to serve it, which drops theaws-sdk-rdsdependency from the genesis path.Compatibility: any deployment config that still passes
--perform-snapshotmust drop the flag before adopting an image with this change, since the argument parser rejects unknown flags.