chore: Update WalletKit to use ZkArtifactSource trait - #458
Open
Dzejkop wants to merge 20 commits into
Open
Conversation
Dzejkop
force-pushed
the
dzejkop/update-walletkit
branch
from
August 4, 2026 09:45
179062b to
a7622ba
Compare
ZkArtifactSource trait
ZkArtifactSource traitZkArtifactSource trait
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 22f52b5. Configure here.
kilianglas
reviewed
Aug 4, 2026
kilianglas
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bumps world-id-protocol crates to
0.13Aligns on the
ZkArtifactSourceAPINote
Medium Risk
Touches authenticator initialization and ZK proof material loading across CLI, FFI, and tests; CI now runs all features including expensive compress paths, increasing blast radius if artifact APIs or caches misbehave.
Overview
Migrates WalletKit to the world-id-protocol
0.13ZkArtifactSourceAPI, replacing the localGroth16Materialstype andcache_embedded_groth16_materialflow withCachingZkArtifacts(filesystem cache + embedded material) andEmbeddedZkArtifacts(UniFFI-friendly wrappers).Authenticator::initand related entry points now takeArc<dyn WalletKitZkArtifactSource>instead of Groth16 materials; core init passes artifacts through toCoreAuthenticator.Dependency and feature alignment: workspace pins
world-id-core/world-id-proof0.13,taceo-oprf0.17, and routesembed-zkeys/compress-zkeysthroughworld-id-proof(embed-zk-artifacts,zk-ownership-verify→embed-zk-artifacts).embed-zkeysbecomes a default feature onwalletkit-coreuntil runtime artifact download exists.CLI, testkit, and tooling: setup/wallet/proof paths use
create_artifact_source/preload(); ownership verification takes an artifact source.register_accountin testkit now requires a storage root for artifacts.CI: WASM check enables
embed-zkeys; Rust tests use cargo nextest with--workspace --all-features(replacing a narrower feature set); non-default-feature build uses--workspace.Reviewed by Cursor Bugbot for commit 54a48ee. Bugbot is set up for automated code reviews on this repo. Configure here.