fix/nitro worker output root rpc - #978
Conversation
* fix: add request timeout to clients * fix: make rpc timeout configurable
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cc17e5d. Configure here.
| l1_beacon_rpc, | ||
| l2_rpc, | ||
| // No op-node in this fixture; the eth_getProof path is expected to succeed. | ||
| None, |
There was a problem hiding this comment.
E2E skips available consensus RPC
Medium Severity
The e2e host config passes None for l2_consensus_rpc with a comment claiming there is no op-node, but this test already requires ROLLUP_RPC_URL as the op-node for output roots. That leaves the new eth_getProof fallback unwired, so any eth_getProof failure fails the run even though a consensus endpoint is available.
Reviewed by Cursor Bugbot for commit cc17e5d. Configure here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>


Stack created with GitHub Stacks CLI • Give Feedback 💬
Note
Medium Risk
Misconfigured L2 consensus URLs could break witness/output-root collection; new L1 RPC timeouts may surface failures on slow providers that previously hung silently.
Overview
Witness building no longer uses the L2 execution RPC for
optimism_outputAtBlockwheneth_getProoffails.OnlineHostConfiggains optionall2_consensus_rpc; Nitro/SP1 workers and the prover CLI expose--l2-consensus-rpc/L2_CONSENSUS_RPC_URL, and missing consensus RPC now fails with an explicit error instead of calling the wrong endpoint.metered_http_clienttakes a per-requestrequest_timeout(default 10s viaDEFAULT_RPC_REQUEST_TIMEOUT_SECONDS). Challenger, defender, and proposer addL1_RPC_TIMEOUT_SECONDSso hung L1 connections cannot block poll loops indefinitely.Devnet SP1 worker passes
Nonefor consensus RPC because local reth serveseth_getProofdirectly.Reviewed by Cursor Bugbot for commit cc17e5d. Configure here.