feat(ui): introduce deploy button - WF-210 #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madeindjs
force-pushed
the
WF-210
branch
3 times, most recently
from
352344b to
9c512cc
Compare
madeindjs
force-pushed
the
WF-210
branch
3 times, most recently
from
9cc0b84 to
a6d7e5f
Compare
Remove the feature flag and use `WRITER_CLOUD` environment variable to start the application in cloud mode (to enable the "deploy" button).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an environment variable
WRITER_CLOUDto start the application in cloud mode (to enable the "deploy" button).It'll enable a button "Deploy" in the navbar
The deploy button will trigger an iFrame message
"deploy". The container can handle this event to do external logic. The button listen the iFrame message"deployStarted"to display a loader, and"deployFinished"to mark it as done.Here is a CodePen demo: https://codepen.io/madeindjs/pen/MYWqvvg