-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement group block in agent editor to support vendor block - WF-181 #772
Open
FabienArcellier
wants to merge
3
commits into
writer:dev
Choose a base branch
from
FabienArcellier:WF-181-implement-group-block-in-workflows-to-support-vendor-block
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81441d1
to
d2492d8
Compare
madeindjs
reviewed
Mar 12, 2025
src/ui/src/builder/settings/BuilderSettingsGroupBlockProperties.vue
Outdated
Show resolved
Hide resolved
* feat: update ActionSelect logic to use new action name retrieval method * feat: add utility functions isGroupNode, getGroupType, and getActionName in core index * fix: ensure correct conditionals for selecting component definitions based on group level * chore: pass group-level attribute in BuilderSettingsBlockProperties template for more explicit rendering * fix: correct v-if conditions in BuilderSettingsMain to use groupNode instead of hasAction * feat: add new Vue components `BuilderSettingsBlockProperties.vue` and `BuilderSettingsGroupBlockProperties.vue` * refactor: update component property handling to accommodate group levels in settings properties components * feat: implement `getComponentFieldsForGroupLevel` function to retrieve fields based on component group levels * show the settings of workflows_workflow * display outs only when they exists * show only action selection when it has subtypes * display the action in workflow block * feat: add WorkflowsNodeGroup.vue component for workflows feature * refactor: restructure AirtableManipulateRecord and AirtableQueryRecords to include group "Airtable" * add python-dotenv as dev dependency * implement workflow blocks * implement functional tests
* remove backend external test, too complicate to maintain
752fb51
to
dfdaf53
Compare
* fix review comment
dfdaf53
to
4cc6e17
Compare
madeindjs
approved these changes
Mar 17, 2025
Comment on lines
+62
to
+117
@import "../sharedStyles.css"; | ||
.form { | ||
display: flex; | ||
flex-direction: column; | ||
gap: 4px; | ||
} | ||
|
||
.title__label { | ||
font-size: 14px; | ||
font-weight: 500; | ||
line-height: 20px; | ||
} | ||
|
||
.selector-container { | ||
position: relative; | ||
} | ||
|
||
.input { | ||
width: 100%; | ||
border: 1px solid #ccc; | ||
border-radius: 8px; | ||
padding: 8px; | ||
|
||
display: flex; | ||
flex-direction: row; | ||
gap: 4px; | ||
} | ||
|
||
.selector-input { | ||
width: 100%; | ||
border: none; | ||
outline: none; | ||
} | ||
|
||
.suggestions-list { | ||
position: absolute; | ||
left: 0; | ||
right: 0; | ||
background: white; | ||
border: 1px solid #ccc; | ||
border-top: none; | ||
border-radius: 0 0 4px 4px; | ||
max-height: 200px; | ||
overflow-y: auto; | ||
z-index: 1000; | ||
margin: 0 24px; | ||
} | ||
|
||
.suggestion-item { | ||
padding: 8px; | ||
cursor: pointer; | ||
} | ||
|
||
.suggestion-item:hover { | ||
background-color: #f0f0f0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this dead code
Suggested change
@import "../sharedStyles.css"; | |
.form { | |
display: flex; | |
flex-direction: column; | |
gap: 4px; | |
} | |
.title__label { | |
font-size: 14px; | |
font-weight: 500; | |
line-height: 20px; | |
} | |
.selector-container { | |
position: relative; | |
} | |
.input { | |
width: 100%; | |
border: 1px solid #ccc; | |
border-radius: 8px; | |
padding: 8px; | |
display: flex; | |
flex-direction: row; | |
gap: 4px; | |
} | |
.selector-input { | |
width: 100%; | |
border: none; | |
outline: none; | |
} | |
.suggestions-list { | |
position: absolute; | |
left: 0; | |
right: 0; | |
background: white; | |
border: 1px solid #ccc; | |
border-top: none; | |
border-radius: 0 0 4px 4px; | |
max-height: 200px; | |
overflow-y: auto; | |
z-index: 1000; | |
margin: 0 24px; | |
} | |
.suggestion-item { | |
padding: 8px; | |
cursor: pointer; | |
} | |
.suggestion-item:hover { | |
background-color: #f0f0f0; | |
} | |
.selector-container { | |
position: relative; | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agent editor blocks can be grouped. The developer customizes the action in the block's context menu.