Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): handle unknown component in Blueprint - WF-193 #797

Merged
merged 3 commits into from
Mar 31, 2025

Conversation

madeindjs
Copy link
Collaborator

@madeindjs madeindjs commented Mar 26, 2025

Customize RenderError.vue to display a WorkflowsNode component for invalid workflow blocks.

It also renders the outs of the nodes.

image

@madeindjs madeindjs self-assigned this Mar 26, 2025
@ramedina86
Copy link
Collaborator

Did you look into doing something aligned with fallbackTemplate in templateMap.ts?

@madeindjs
Copy link
Collaborator Author

Did you look into doing something aligned with fallbackTemplate in templateMap.ts?

@ramedina86 I'm not sure that it is needed. We display the error component from here

return renderErrorVNode(
vnodeProps,
"Parent is not suitable for this component",
);

So I'm just customizing the component RenderError inside WorkflowsWorkflow. It just allows the user to see the broken node and remove it if needed.

Do you think I'm missing something?

I simply customize the component `RenderError.vue` and make it looks
like a node using CSS `:deep`.
@madeindjs madeindjs marked this pull request as ready for review March 31, 2025 14:44
@madeindjs madeindjs merged commit 31b628a into writer:dev Mar 31, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants