feat: dockerize (with requested changes) #2392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoughtscript
commented
Jun 29, 2025
| A barebones [dockerfile](./dockerfile) is supplied to run the site within a local Docker Container through [Docker Desktop](https://docs.docker.com/desktop/) - a simple, free, way to easily setup Docker and Python without leaving beyond installations, modifying your underlying Operating System, and changing Environment Variables. | ||
|
|
||
| 1. Make sure Docker Desktop is running and started | ||
| 1. Build the Docker Image from the root directory with the command: `docker build -t wtd .` |
There was a problem hiding this comment.
@plaindocs - I tweaked the recommended build per your prior comment here: #2379 (comment) - loved that suggestion - thanks!
Thoughtscript
commented
Jun 29, 2025
|
|
||
| RUN chmod +x make.bat | ||
|
|
||
| # The following CMD is run every time the Container starts |
There was a problem hiding this comment.
This actually took a bit - thought I could simply copy over my prior BASH script but it seems I need to/should reset the WORKDIR to use CMD (over ENTRYPOINT) for a slightly more succinct command.
Thoughtscript
commented
Jun 29, 2025
| sphinx-autobuild --port 8888 -j auto --watch _data -b dirhtml $(ALLSPHINXOPTS) $(BUILDDIR)/html | ||
|
|
||
| # Used solely to bind sphinx to the Docker Container - to do so requires deliberately setting --host "0.0.0.0" | ||
| dockerhtml: |
There was a problem hiding this comment.
Added comments per request.
|
Thanks for the fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I've gone ahead and Dockerized the repo. I've also addressed issues, suggestions, and concerns raised here: #2379 (and made a new PR - apologies, I thought this might get a bit more involved but the solution ended up being a bit more elegant/made some typos/excessive errata's in the last "draft").
📚 Documentation preview 📚: https://writethedocs-www--2392.org.readthedocs.build/