Skip to content

chore(docs): README truth-up against landed PRs — counts, stale claims, missing rows#119

Merged
thewrz merged 1 commit into
mainfrom
chore/readme-validation
Jun 7, 2026
Merged

chore(docs): README truth-up against landed PRs — counts, stale claims, missing rows#119
thewrz merged 1 commit into
mainfrom
chore/readme-validation

Conversation

@thewrz
Copy link
Copy Markdown
Contributor

@thewrz thewrz commented Jun 7, 2026

Summary

In-depth validation of every factual README claim against the repo state and merged PR history. Every count, PR number, endpoint, tool name, table name, and referenced path was independently verified; this PR fixes the eight discrepancies found.

Fixed inaccuracies

Verified accurate (no change needed)

All 11 API endpoints vs src/api/router.ts; all 7 MCP tools + 2 resources vs src/mcp/; seed counts recounted from corpus (666 distinct records / 239 Level 4/5 suffixed / 31 divisions — exact match); migration-013 CHECK constraint claims; every other phase-table PR number (17, 21, 76, 66, 70, 75, 72, 74, 69, 71, 24, 26, 51, 55, 114–117 — all MERGED with matching titles); Node 22; /mcp rate limiting; piscina pool; all 9 referenced doc paths.

Test Plan

  • pnpm lint — clean (verified locally)
  • pnpm test — 588 passed (verified locally)
  • node -e "..." glob check: 'docs/references/UFGS/**/*.SEC' + 'docs/references/UFGS/**/*.sec' together match 666 files (verified locally: 665 + 1)
  • Spot-check README claims against src/api/router.ts and src/mcp/tools.ts

Out of scope: any src/ behavior change beyond the one-line seed:corpus glob; renaming 01_42_00.sec; ARCHITECTURE.md audit.

Summary by CodeRabbit

  • Documentation

    • Updated project roadmap and Phase 2c progression status
    • Enhanced feature documentation with details on PART heading recognition and SEC file parsing behavior
    • Updated setup and configuration instructions including newly supported schema components
    • Updated corpus reference documentation
  • Chores

    • Updated build scripts to support multiple reference file format variants

…s, missing rows

In-depth validation of every factual README claim against the repo and
merged PR history. Fixes found inaccuracies:

- UFGS corpus is 666 SEC files (665 *.SEC + 1 lowercase 01_42_00.sec),
  not 665 — README said 665 in two places while itself claiming 666
  seeded section records. seed:corpus glob was case-sensitive and
  silently skipped the lowercase file; second glob pattern added so
  "load all 666" is actually true.
- Phase 2b-iv cited "PR #58" — #58 is a closed issue; the feature
  merged as PR #60.
- Status table omitted landed work: 2c-i style_templates/style_rules
  schema (PR #87) and 4a revit_parameter_mappings schema (PR #86).
- "Not Yet Built" still listed persistTree/persistSpec consolidation —
  landed in PR #88 (parse path persists refs via persistParsedSpec).
- DB schema list said "versions" (actual: paragraph_versions) and
  omitted spec_sections, style_templates, style_rules,
  revit_parameter_mappings.
- .mcp.json described as "in the repo root" — it is gitignored
  (*.mcp.json); reworded to "create".
- Parsing section now covers PR #112 (SEC XML entity decoding) and
  PR #113 (numbering-generated PART headings, specifier-note
  detection, sanity post-pass).

Verified accurate (no change needed): all 11 API endpoints, all 7 MCP
tools + 2 resources, seed counts (666 records / 239 suffixed / 31
divisions — recounted from corpus), migration-013 CHECK constraint
claims, all other phase-table PR numbers, Node 22, rate limiting,
piscina pool, all referenced doc paths.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 7, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0e598518-ec16-4e7d-9e4e-54048daf49b9

📥 Commits

Reviewing files that changed from the base of the PR and between a99298e and 9956667.

📒 Files selected for processing (2)
  • README.md
  • package.json

📝 Walkthrough

Walkthrough

This PR updates SpecR project documentation and configuration to reflect Phase 2c-i database schema completion, expands "What Works Today" feature documentation, updates setup instructions with additional schema components, and modifies the seed:corpus script to load UFGS reference files in both uppercase and lowercase formats.

Changes

Documentation and Configuration Updates

Layer / File(s) Summary
Project Roadmap and Status
README.md
Phase 2c status text updated to specify Phase 2c-i DB schema completion, and roadmap table reordered to insert Phase 2c-i as completed and adjust surrounding phase entries.
Feature Capabilities and Documentation
README.md
"What Works Today" section expanded with bullets describing PART heading detection with hidden NOTE TO SPECIFIER handling and SEC XML character entity decoding, while removing obsolete persistTree/persistSpec consolidation note.
Setup Instructions and Reference Data
README.md, package.json
Database schema components expanded to include paragraph_versions, style_templates/style_rules, and revit_parameter_mappings; seed:corpus script updated to load both .SEC and .sec UFGS files; UFGS corpus reference count adjusted to 666 files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • wrzonance/SpecR#77: Adds the persistTree/persistSpec consolidation note in the "follow-up" section that this PR removes, and similarly updates "What Works Today" documentation regarding DOCX/parsing behavior.

Poem

🐰 The roadmap marches onward bright,
Phase 2c-i schema shines with light,
New features bloom in docs so clear,
Case-insensitive files appear,
The setup guide now greets us right! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main purpose of this PR: updating the README documentation to correct inaccuracies, update counts, fix stale claims, and add missing rows in tables. The title directly reflects the content validated in the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/readme-validation

Comment @coderabbitai help to get the list of available commands and usage tips.

@thewrz thewrz merged commit 7e45816 into main Jun 7, 2026
4 of 5 checks passed
@thewrz thewrz deleted the chore/readme-validation branch June 7, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant