chore(docs): README truth-up against landed PRs — counts, stale claims, missing rows#119
Conversation
…s, missing rows In-depth validation of every factual README claim against the repo and merged PR history. Fixes found inaccuracies: - UFGS corpus is 666 SEC files (665 *.SEC + 1 lowercase 01_42_00.sec), not 665 — README said 665 in two places while itself claiming 666 seeded section records. seed:corpus glob was case-sensitive and silently skipped the lowercase file; second glob pattern added so "load all 666" is actually true. - Phase 2b-iv cited "PR #58" — #58 is a closed issue; the feature merged as PR #60. - Status table omitted landed work: 2c-i style_templates/style_rules schema (PR #87) and 4a revit_parameter_mappings schema (PR #86). - "Not Yet Built" still listed persistTree/persistSpec consolidation — landed in PR #88 (parse path persists refs via persistParsedSpec). - DB schema list said "versions" (actual: paragraph_versions) and omitted spec_sections, style_templates, style_rules, revit_parameter_mappings. - .mcp.json described as "in the repo root" — it is gitignored (*.mcp.json); reworded to "create". - Parsing section now covers PR #112 (SEC XML entity decoding) and PR #113 (numbering-generated PART headings, specifier-note detection, sanity post-pass). Verified accurate (no change needed): all 11 API endpoints, all 7 MCP tools + 2 resources, seed counts (666 records / 239 suffixed / 31 divisions — recounted from corpus), migration-013 CHECK constraint claims, all other phase-table PR numbers, Node 22, rate limiting, piscina pool, all referenced doc paths.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR updates SpecR project documentation and configuration to reflect Phase 2c-i database schema completion, expands "What Works Today" feature documentation, updates setup instructions with additional schema components, and modifies the seed:corpus script to load UFGS reference files in both uppercase and lowercase formats. ChangesDocumentation and Configuration Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
In-depth validation of every factual README claim against the repo state and merged PR history. Every count, PR number, endpoint, tool name, table name, and referenced path was independently verified; this PR fixes the eight discrepancies found.
Fixed inaccuracies
*.SEC+ 1 lowercase01_42_00.sec(in the corpus since the initial commit). The README said 665 in two places while itself claiming 666 seeded section records.seed:corpussilently skipped the lowercase file — the glob was case-sensitive, so "load all" loaded 665 of 666. Second glob pattern added topackage.json; the claim is now true (verified: 665 + 1 = 666 matched).style_templates/style_rulesschema (PR feat(db): Phase 2c-i — style_templates + style_rules + default style_rules seed #87) and 4arevit_parameter_mappingsschema (PR feat(db): Phase 4a — Revit parameter mapping schema + migrations #86), both merged 2026-05-19.persistTree/persistSpecconsolidation landed in PR refactor(api): consolidate persist path onto persistParsedSpec (fixes silent ref loss on POST /parse) #88 (src/api/parse.tspersists refs viapersistParsedSpec); removed.versions→paragraph_versions; added missingspec_sections,style_templates,style_rules,revit_parameter_mappings..mcp.jsonwording — it is gitignored (*.mcp.json), not "in the repo root"; reworded to "create".Verified accurate (no change needed)
All 11 API endpoints vs
src/api/router.ts; all 7 MCP tools + 2 resources vssrc/mcp/; seed counts recounted from corpus (666 distinct records / 239 Level 4/5 suffixed / 31 divisions — exact match); migration-013 CHECK constraint claims; every other phase-table PR number (17, 21, 76, 66, 70, 75, 72, 74, 69, 71, 24, 26, 51, 55, 114–117 — all MERGED with matching titles); Node 22;/mcprate limiting; piscina pool; all 9 referenced doc paths.Test Plan
pnpm lint— clean (verified locally)pnpm test— 588 passed (verified locally)node -e "..."glob check:'docs/references/UFGS/**/*.SEC'+'docs/references/UFGS/**/*.sec'together match 666 files (verified locally: 665 + 1)src/api/router.tsandsrc/mcp/tools.tsOut of scope: any
src/behavior change beyond the one-lineseed:corpusglob; renaming01_42_00.sec; ARCHITECTURE.md audit.Summary by CodeRabbit
Documentation
Chores