Fix serialize bug on detached / continuation mismatch #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorYing
reviewed
Jul 23, 2018
lib/Transforms/Utils/SimplifyCFG.cpp
Outdated
| return false; | ||
| if (auto DI = dyn_cast<DetachInst>(PredBB->getTerminator())) { | ||
| // check that we are the detached (and not continuation) | ||
| return DI->getDetached() == BB; |
There was a problem hiding this comment.
You don't want to return true here. You've made the actual simplification dead!
|
Indeed, resolved. |
neboat
reviewed
Jul 23, 2018
| return false; | ||
| if (auto DI = dyn_cast<DetachInst>(PredBB->getTerminator())) { | ||
| // check that we are the detached (and not continuation) | ||
| if(DI->getDetached() != BB) return false; |
There was a problem hiding this comment.
For consistent code style, I'd prefer a space between the if and first (.
|
Can we get a regression test for this bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
@VictorYing