Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification Template API] Event Handler Implementation #250

Conversation

RushanNanayakkara
Copy link
Contributor

@RushanNanayakkara RushanNanayakkara commented Jul 10, 2024

Purpose

Implement event handling functions for Notification Template API which supports template operations for all available notification channels. (Email, SMS)

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Related Issues

Related PRs

pom.xml Outdated
@@ -477,7 +477,7 @@

<properties>
<!--Identity Governance Version-->
<identity.governance.version>1.10.0</identity.governance.version>
<identity.governance.version>1.11.4-SNAPSHOT</identity.governance.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snapshot versions need to be bumped after dependent PRs are merged. The snapshot values will be replaced with new release versions.

Avarjana
Avarjana previously approved these changes Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 395 lines in your changes missing coverage. Please review.

Project coverage is 16.73%. Comparing base (a4f3258) to head (e012ab9).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
...bon/email/mgt/NotificationTemplateManagerImpl.java 0.00% 305 Missing ⚠️
...rbon/email/mgt/constants/TemplateMgtConstants.java 0.00% 29 Missing ⚠️
...l/mgt/store/TemplatePersistenceManagerFactory.java 0.00% 16 Missing ⚠️
...mail/mgt/store/dao/AppNotificationTemplateDAO.java 0.00% 14 Missing ⚠️
...carbon/email/mgt/store/DBBasedTemplateManager.java 0.00% 9 Missing ⚠️
.../email/mgt/store/RegistryBasedTemplateManager.java 0.00% 8 Missing ⚠️
.../carbon/email/mgt/store/HybridTemplateManager.java 0.00% 5 Missing ⚠️
...o/cache/CacheBackedAppNotificationTemplateDAO.java 0.00% 4 Missing ⚠️
...carbon/email/mgt/store/UnifiedTemplateManager.java 0.00% 3 Missing ⚠️
.../email/mgt/store/SystemDefaultTemplateManager.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
- Coverage     19.21%   16.73%   -2.49%     
  Complexity      175      175              
============================================
  Files            50       53       +3     
  Lines          2659     3054     +395     
  Branches        305      338      +33     
============================================
  Hits            511      511              
- Misses         2107     2502     +395     
  Partials         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11481426566

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11481426566
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11481426566

@RushanNanayakkara RushanNanayakkara merged commit 71a563c into wso2-extensions:master Oct 23, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants