Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unicode data type support for notification templates #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darshanasbg
Copy link
Contributor

@darshanasbg darshanasbg commented Nov 7, 2024

Proposed changes in this pull request

$subject.

Related with

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 2.10526% with 93 lines in your changes missing coverage. Please review.

Project coverage is 16.80%. Comparing base (8826274) to head (ded1925).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...mail/mgt/store/dao/AppNotificationTemplateDAO.java 2.08% 47 Missing ⚠️
...mail/mgt/store/dao/OrgNotificationTemplateDAO.java 2.12% 46 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #274      +/-   ##
============================================
- Coverage     17.00%   16.80%   -0.20%     
  Complexity      179      179              
============================================
  Files            53       53              
  Lines          3046     3094      +48     
  Branches        335      349      +14     
============================================
+ Hits            518      520       +2     
- Misses         2487     2533      +46     
  Partials         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darshanasbg darshanasbg changed the title Add unicode data type support for org templates Add unicode data type support for notification templates Nov 7, 2024
UdeshAthukorala
UdeshAthukorala previously approved these changes Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants