Optimize cleanupTokenByTokenValue logic #2508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
...rbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/dao/OldTokensCleanDAO.java
Outdated
Show resolved
Hide resolved
|
PR builder completed |
jenkins-is-staging
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9695418391
| @@ -64,48 +64,57 @@ public void cleanupTokenByTokenId(String tokenId, Connection connection) throws | |||
| } | |||
| } | |||
|
|
|||
| public void cleanupTokenByTokenValue(String token, Connection connection) throws SQLException { | |||
There was a problem hiding this comment.
is it ok to remove public method here?
| * @param connection Database connection. | ||
| * @throws SQLException If an error occurs while cleaning up the token. | ||
| */ | ||
| public void cleanupTokenByTokenValue(String tokenHash, Connection connection) throws SQLException { |
There was a problem hiding this comment.
name should be cleanupTokenByTokenHash ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
In this PR the
cleanupTokenByTokenValuemethod will be optimized so that the select query related to prepare theoldAccessTokenObjectwill be executed only when theretain_access_tokens_for_auditingconfig is enabled.A new token deletion logic has been introduced to use the token hash, instead of the ID.
Related issues: wso2/product-is#20601