Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property "renew_token_without_revoking_existing" not being honored causing stuck threads #2625

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KD23243
Copy link

@KD23243 KD23243 commented Nov 12, 2024

Proposed changes in this pull request

  • Skip checking for existing token when renew_without_revoking_existing is enabled, the binding type is set to "none," and generate a random UUID as the binding reference. This avoids thread stuck issues.
  • Support for reading the token type from the following Deployment.toml configurations and correctly retrieves the token type to initialize the "renew_token_without_revoking_existing" flow.
//Adding custom token issuers
[[oauth.extensions.token_types]]
name = "CustomTokenIssuer"
issuer = "org.wso2.carbon.identity.extensions.CustomJWTTokenIssuer"
persist_access_token_alias = true
type = "jwt"

//Changing the default token issuer
[oauth.extensions]
token_generator = "org.wso2.carbon.identity.extensions.CustomJWTTokenIssuer"
token_type = "jwt"

Resolves

When should this PR be merged

This PR should be merged after merging the following PR.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 48.14815% with 28 lines in your changes missing coverage. Please review.

Project coverage is 55.43%. Comparing base (dc41ff9) to head (480cd3f).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...dentity/oauth/config/OAuthServerConfiguration.java 20.00% 12 Missing ⚠️
...dlers/grant/AbstractAuthorizationGrantHandler.java 66.66% 1 Missing and 10 partials ⚠️
...o2/carbon/identity/oauth2/model/TokenIssuerDO.java 16.66% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2625      +/-   ##
============================================
+ Coverage     53.35%   55.43%   +2.07%     
+ Complexity     8589     8150     -439     
============================================
  Files           632      632              
  Lines         52956    47163    -5793     
  Branches       9069     8300     -769     
============================================
- Hits          28253    26143    -2110     
+ Misses        20597    17285    -3312     
+ Partials       4106     3735     -371     
Flag Coverage Δ
unit 38.69% <48.14%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KD23243 KD23243 force-pushed the renew_token_without_revoking_existing branch from 65305d6 to 480cd3f Compare November 13, 2024 04:13
@KD23243 KD23243 marked this pull request as draft November 13, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant