Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to drop standard port when getting configuration value #6600

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AmshikaH
Copy link
Contributor

@AmshikaH AmshikaH commented Mar 11, 2025

Purpose

Adds method to drop the standard ports, namely 443 for https and 80 for http, when getting configuration value.

Related Issues

Related PRs

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 46.97%. Comparing base (93dcdb1) to head (5a2e0d5).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
...g/wso2/carbon/identity/core/util/IdentityUtil.java 60.00% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6600      +/-   ##
============================================
+ Coverage     46.91%   46.97%   +0.05%     
- Complexity    15547    15556       +9     
============================================
  Files          1800     1802       +2     
  Lines        107397   107400       +3     
  Branches      19800    19790      -10     
============================================
+ Hits          50390    50453      +63     
+ Misses        49936    49860      -76     
- Partials       7071     7087      +16     
Flag Coverage Δ
unit 31.04% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13802995363

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13802995363
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13804832151

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13804832151
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13804832151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants