Rename the partner schema section to match the term used elsewhere - #633
Merged
Conversation
niveathika
requested review from
KavinduZoysa,
NipunaRanasinghe,
anupama-pathirage and
rosensilva
as code owners
August 23, 2026 12:34
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…"adapt" Both envelope samples called methods on `txn.body` after an `is error` check on that same field access. Ballerina narrows variable references, not field accesses, so the body stays `json|error` / `ORDERS|error` in that branch: `.message()` and `.toString()` are undefined on it, and passing it to `log:printError`'s `error` parameter is a type error. Bind it to a local first; verified both forms fail and both fixes run. "Custom EDI schemas" also covered two different things — a proprietary format with no specification to convert from, and tuning a converted schema for one partner. Keep the section for the first and link the second to "Adapting the schema to a trading partner".
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Transform > EDI Processingcalls the section "Adjusting a schema for a trading partner", while the Ballerina EDI tool page called the same thing "Changing the specification for a trading partner" and the BBEs used a third phrasing. Three names for one concept.Settling on "Adapting the schema to a trading partner" everywhere: the published specification is never changed — the schema derived from it is — and "adapt to" frames it as conforming to what the partner sends rather than optional personalization.
Matching renames are in flight:
Checklist