Update Azure Files docs for connector 1.0.1 and drop version pins - #653
Merged
Conversation
- Rename the RetryPolicyType member FIXED to FIXED_INTERVAL (the configuration value stays "fixed"); LeaseDuration.FIXED is a separate enum and is unchanged. - Pin the overview to v1.0.1. - Add the catalog card icon, now that the package is published on Ballerina Central. - Note that a handler panic also triggers afterError, matching the file-integration guide. Claude-Session: https://claude.ai/code/session_01Fei1vWUdteHyjXBFaYUmMT
YasanPunch
requested review from
KavinduZoysa,
NipunaRanasinghe,
anupama-pathirage and
rosensilva
as code owners
September 7, 2026 04:03
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
niveathika
approved these changes
Sep 7, 2026
Nuvindu
reviewed
Sep 7, 2026
A pinned version goes stale on the next release with nothing to update it, as the Azure Files page did within two days of publishing. Readers get the current version from Ballerina Central, which the catalog card already links to. The remaining pinned pages are tracked in wso2-enterprise/integration-engineering#2751. Claude-Session: https://claude.ai/code/session_01Fei1vWUdteHyjXBFaYUmMT
daneshk
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #617, syncing the merged Azure Files docs to
ballerinax/azure.storage.files1.0.1, plus a small convention change.1.0.1 sync
RetryPolicyType.FIXED→FIXED_INTERVAL— renamed in 1.0.1. The configuration value stays"fixed", so only the enum member name changes.LeaseDuration.FIXEDis a different enum and is deliberately left alone.iconwas omitted back when 1.0.0 was unpublished.afterErrorrow now says "returns an error or panics", matching both the 1.0.1 behaviour fix and the wording already in the file-integration guide.Version pins dropped (Azure Files + FTP)
Rather than bump the Azure Files overview to v1.0.1, the pin is removed. A pinned version goes stale on the next release with nothing to update it — this page was stale within two days of publishing — and readers get the current version from Ballerina Central, which the catalog card already links to. FTP's
(v2.19.0)pin is removed for the same reason, as the other file-integration page our team owns that carries one.The card icon URL keeps its version deliberately: Central's icon CDN requires one in the filename (the versionless URL 404s) and old URLs keep serving, so a pinned icon is invisible to readers.
The remaining pinned pages across the catalog belong to other teams and are tracked in wso2-enterprise/integration-engineering#2751.
The restored
onFileCsvstring row forms, the other notable 1.0.1 change, were already documented in #632.Verified by compiling the documented samples against 1.0.1 resolved from Ballerina Central, including
files:FIXED_INTERVAL. Site build is clean apart from two pre-existing5.1.xwarnings unrelated to these pages.